Focus change plugin added workspace ignore flag and changed some logic in regards to cross-output functionality #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for ignoring or respecting workspace bounds (before it would always ignore it)
…l-and-workspace-ignore-flag
soreau
requested changes
Dec 28, 2023
|
Actally, I use get_output() elsewhere, I will have to add some checks. |
|
hopefully this is a bit better now? |
|
@soreau any chance to merge this asap? |
soreau
approved these changes
Dec 30, 2023
soreau
pushed a commit
that referenced
this pull request
Mar 15, 2024
…egards to cross-output functionality (#222)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes how outputs are selected when using cross-output and added a setting to optionally ignore workspace boundaries (views can only be focused if it's in the current workspace)
Overall I consider this code an improvement and fixes some annoyances I had with the plugin where it would not respect workspace boundaries and it was impossible to change via an option.