Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First child of a group has a different frame level than the other auras in that same group #4741

Closed
2 tasks done
Ricodyn opened this issue Dec 3, 2023 · 8 comments
Closed
2 tasks done
Labels
⏱ Awaiting Response This ticket hasn't been triaged yet. 🐛 Bug This is a problem with WeakAuras.

Comments

@Ricodyn
Copy link

Ricodyn commented Dec 3, 2023

Is there an existing issue for this?

  • I have searched the existing open and closed issues.

Description

The first WeakAura in a group doesn't always have the same frame level as the other auras in the group. Reverting the changes in commit f00565f fixes this.

WeakAuras Version

WeakAuras 5.8.7

World of Warcraft Flavor

Retail (Default)

World of Warcraft Region

EU

Tested with only WeakAuras

  • Yes

Lua Error

No response

Reproduction Steps

Create a group and create an Aura in that group.
Set 'Anchored To' to 'Select Frame' and check 'Set Parent to Anchor'.
Select a Frame, for example the PlayerFrame or a bar button.
Duplicate the Aura.

The first Aura (top child in the group) seems to have a different frame level from the duplicate.

Last Good Version

Weakauras 5.8.5

Screenshots

The only difference between the two images is which aura is the first in the group. That first child appears behind the character frame and seems to have a different frame level from the other auras, as the other 3 appear correctly in front.
Test

Export String

!WA:2!vx1tVTXXv8qSjijlqsKyKLTCTtvCrCtDBuDKQ(tCqtkxksj5qrsTCLLSDs5(VHC3Ov7UEMz1)ABASksIsaYf9nO8CpXl1N6b9j4bI(jqh8PEsFc6BMDjLKLlkqasb6LHZ8M3SZ8E)(dZDV8m9PNyUjMn)M5DZ7EW17zB5SHlnkUyuqe9Ukkk1vU9etFSDe1Lq1Y2mEiTa)92ZI6oUruua3pUdpYzlcL5hfELCFJNoZXkGOyNEmp6U1A1Ir456Af64frRh5hYTlwQQrj9oP50WFpYl1nDE6DNlxof6o9py6olfIluOwoC8IyZOZ4wuUQMFOpx1Uf(dZtDFo1VDB8TC1BsZM(1DCj2jTAzSBmHUyPk1lVAfnoUq3kHAn5(SysqWsUm1Jzj2KTiH8gy2(70TzXcnmA2WOGUHwcEj2Xbw7sOdsRoLGPP3OEPkv0LrSxKyfW90dT2KWupmjm7jOMvNLCBtIhUXJsSOKXlNeem(AE(CYrP7MwTVAhkPnwGINREBAus8HwH(BAjk6zGHkdxwlmkKCeXIrAWPKW2CVxUNlwkImAkkmkJ4ef6Y2xKJ47a3sBtl)q8SWTGF5ld)k49GjWP5F2i3W39qdcJVG4ETXpsl)2QDBrX6bVllULYjPGyzriXN2Urr9sLQQfez5wwJHa5O6BMGScvnSX6mkmRQUtGfJjMzZrIrixmDYeF3US41N5rpiA2QZ9bNGKccn0k4EPePVVd2M1LDcStYibTK8gqTJO08Lua1U(HTIOP9g1EwjC8LvloDV8o39GB2XhZUruc1HCTxaETvGx5sWRcQ9CqIRB02Hn22pMyEu)Lc8XttCgt4nF9BcJ8uS)CT48jmstlBwevcWlh5smHRc)KEyR2bRhpjQF183gghEB4gQW1GRdVf8tHXup(0Jkp2(I1cYKz8WIPN7lygp65w3mcxAXJOxn)hbxcgf(zQXdlO)BrmsjwIV5F7fGF73FYgesCbrhNRlAhEWhJTkxcZIlygep4JUZOWL7HnvHixWRcDpyK48CYo8MmplS8xptUfpMmOCiT92KLnbU1Hd27gVdlEOZC8tfUhNgTpMPvyvJAXVPmiIrrc8YznFxUNwbC5jPxK)oexzWh3lLID)SNZrY9)8eg3V1UyrrJ4ybzGb1QwRAj4YuSOe50rMOtFVlLdZQGqE8qLP(7n(kjwUcs84ggNRW7Ft9KX2gfJRrTI3FTSjPpGT8z(2beZSA(mEzXdVu1QL0BQvZWO2Y6lTWIg9gC1cRTXYQO1p39i2v6jvBvJklvT0t71oiA7YuYJsiHo7w)fV9etoDA1j24iXW8zYCL9fReNUNDcNhfwd9Fr3PoIWvKEcxQRyE)s7qXIb26khHCVf6hXtMz)hNMyHNm)gsFC5ZYWZ3zJqcJPi3PIpoFy5TPL6YB7r8B7XFimDzygHahMto(bYX7igJh6mEhYHU1LoQY5WphklvAfZeJi3gPYOs7xKA7DERRF9)DZS97lRn766ZeM3lHk7Rm3t(hOk60xsD0moKBcAOr1Ggu8i9pSGOnVpZcXExp49vHxs8FCOrPMWOuFBbL9HWKkWuDBuQsPIgL1lSCjDRGyplf4d7U26rBUZ8vyRevN6hk(Bsum(gyjPcdRc5vHFNkuqvBVOOnZDWnHIcFQ)AMpfmVjuYdkFw3iybP3dS4Z1VbwYeURj8jMqLtnnGLLEeqvPRaulZmaQFWiWk5aDSR1avZGHu9cRc3dwdwhU)JHhKdEiEIpf(mm9Fp0u2BatWcSZboGlGWtlOn4ng4Nd(CyJNcb9jUWMa3dIGy4rxcO5aw6HdvGKCWokW2kWwEWUdd75b)bjV5oxG3KYK(JWFsWoGVrbbjSzbFjcI)D4XMz9X8Yw53Ld721O7oJwJs7T4Ivhau2cGA8jHV6HWxyctbFTaTqG8B9G)Ixg7czncYZzyxptK8xicIB)ztyFzvLbC4R7v(x5(Xb5(HQc(FiCJq7fGBKcGWnc0iCJG(zH7)d2edGBeSe0vSjlW7NiW70UTqGGO9z0IPq8usWfzjFLuq(HDF3L3O4ufCOnwTUaTVGQdX)(sUv(Xd5()An3xyMP5Wg2ZtWv3D6v25(pG6oP3ZGg)Mmyidtgi4YWWVKo1SV)StD7Pfa8pury(T(NR)Vd
@Ricodyn Ricodyn added the 🐛 Bug This is a problem with WeakAuras. label Dec 3, 2023
@github-actions github-actions bot added the ⏱ Awaiting Response This ticket hasn't been triaged yet. label Dec 3, 2023
@InfusOnWoW
Copy link
Contributor

With your setup the icons are in the frame strata medium. The PlayerFrame is also in the frame strata medium. The exact ordering of frames in the same frame strata depends on the frame levels.

WA automatically assigns frame levels to auras in a group, to minimize interference between auras in the same group.

But for ordering between the game's frames and the group, you have to use a different frame strata.

@Ricodyn
Copy link
Author

Ricodyn commented Dec 6, 2023

Before the changes in commit f00565f, all Auras in a group would appear above the parent anchor. After the changes, only the first entry in a group appears below the parent, with all others being displayed as they always have. This stays consistent even if you re-order the auras in a group. You can leave the auras themselves untouched, but if you move an aura into the first slot of a group, its frame level changes, as does the frame level of the aura that used to be first.

This behaviour seems unwanted to me, especially since it didn't used to do this in previous versions. I would expect that changing the order in the group should have no impact in relation to other frames, but only to other auras in the same group. In a more general sense, it seems off that a function only applies to the first aura in a group and not all of them.

Looking at the code in commit f00565f, it seems likely that the original frame level that is assigned to the auras in the group is consistent, but that the frame level of only the first aura in a group is at some point overwritten, causing this behaviour to occur.

@InfusOnWoW
Copy link
Contributor

Yes the behaviour has changed slightly. No what you describe is not a correct.

The frame strata is applied to all children. Again, the PlayerFrame is on the same frame strata as your auras, which then leads to the order depending on the frame level.

@Ricodyn
Copy link
Author

Ricodyn commented Dec 6, 2023

Your first reply made me aware that my initial interpretation was incorrect and that this does not relate to frame strata, that all auras are still on the same one. However, in my last reply I did not mention strata at all, I merely talked about frame level, and about how I think the frame level of only the first entry in a group is overwritten, and thus creates the situation that that aura has a different order within the strata compared to the other auras in the group.

So keeping that in mind, how is my description not correct? Or if it is correct, is this behaviour not unwanted?

@InfusOnWoW
Copy link
Contributor

The frame level is not overwritten. Again, as I already explained:
WA automatically assigns frame levels to auras in a group, to minimize interference between auras in the same group.

But for ordering between the game's frames and the group, you have to use a different frame strata.

@Ricodyn
Copy link
Author

Ricodyn commented Dec 6, 2023

In the screenshot I provided I have 2 images of the same group of auras with exactly the same settings within the individual auras. The only difference is that the left image has the top left icon in the first entry of that group, whereas the right image has the top right aura in the first entry. So only the first entry appears behind the player frame, whereas the others do not. Do you know why this happens and could you explain that to me?

And more importantly, if I revert the changes in commit f00565f, and only those changes, this no longer happens. With those couple of lines reverted, changing the order of the auras in the group changes nothing, and regardless of order all four auras appear in front of the player frame.

I understand that frame strata does not play a role here at all, in all cases the player frame and auras all remain on the same strata. And if you say that frame level is not changed or overwritten, what else is causing this behaviour?

@Ricodyn
Copy link
Author

Ricodyn commented Dec 6, 2023

It seems that my issue is closely related to issue #4718. The commit that I mentioned multiple times as the cause of my issue, f00565f, was part of an attempt to fix this other issue. Although details differ, dynamic vs normal groups & retail vs classic, and our issues have come and went with different WA versions, the core seems very similar:

The first entry of a group does not seem to get the same frame level as other auras in the group, causing unwanted and unexpected behaviour.

@Ricodyn Ricodyn changed the title First child of a group doesn't properly inherit Frame Strata First child of a group has a different frame level than the other auras in that same group Dec 6, 2023
@InfusOnWoW
Copy link
Contributor

InfusOnWoW commented Dec 6, 2023

Do you know why this happens and could you explain that to me?
WA automatically assigns frame levels to auras in a group, to minimize interference between auras in the same group.

It seems that my issue is closely related to issue #4718.

No, it's unrelated. #4718 is an issue because we assign the wrong frame level to the backdrop of the group, and thus the automatic assignment of frame levels lead to the auras being behind the backdrop.

Your "issue" is about the ordering between a group and frame that is provided by the game. And for that I can only repeat myself:
But for ordering between the game's frames and the group, you have to use a different frame strata.

There are no gurantees what the relative frame level of auras vs unrelated frames is.

@WeakAuras WeakAuras locked and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
⏱ Awaiting Response This ticket hasn't been triaged yet. 🐛 Bug This is a problem with WeakAuras.
Projects
None yet
Development

No branches or pull requests

2 participants