Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Subzone load condition #4758

Closed
Ricodyn opened this issue Dec 12, 2023 · 3 comments
Closed

Add a Subzone load condition #4758

Ricodyn opened this issue Dec 12, 2023 · 3 comments
Labels
🎨 Feature Request This is a request for a new feature, or an expansion of an existing feature.

Comments

@Ricodyn
Copy link

Ricodyn commented Dec 12, 2023

Is your feature request related to a problem? Please describe.
There is currently no option to load based on GetSubZoneText(), only GetRealZoneText(). (And Zone IDs of course.)

Describe the solution you'd like
Either an additional option in the load conditions that works exactly like the existing Zone Name condition, just with subzones instead.
or
Add support for subzone names in the already existing Zone Name condition, similar to how the Zone ID supports both individual and Group Zone IDs.

Describe alternatives you've considered
You can check for the current subzone using custom triggers, which is effective and makes this feature request not strictly necessary. Adding it to the load conditions seems relatively straightforward however, unless I'm missing something, and might be a nice small quality upgrade in some situations.

@Ricodyn Ricodyn added the 🎨 Feature Request This is a request for a new feature, or an expansion of an existing feature. label Dec 12, 2023
@InfusOnWoW
Copy link
Contributor

What's the use case for this?

@Ricodyn
Copy link
Author

Ricodyn commented Dec 12, 2023

You'd use this if you want a weakaura to only load in a specific subzone rather than in the whole zone.

For me specifically, this came up when I was trying to make a reminder weakaura to change my talents/equipment in a raid. Different bosses in a raid are often in different subzones, so if I want a weakaua to remind me to swap talents for a specific boss, loading a weakaura based on subzone could be helpful.

This could also be useful if you only want specific weakauras to appear in a specific part of a city. Perhaps you have crafting related weakauras that you'd only want to load while in The Artisan's Market, rather than in the whole of Valdrakken. A load option would allow you to do this without custom triggers.

@InfusOnWoW
Copy link
Contributor

There's no locale-independent way to check for the sub zone, as they apparently have no id in the api. I'd be very reluctant to add anything that will lead to locale-dependant auras, it needs to come with some much needed benefit.

The boss specific reminder, while somewhat useful, doesn't really clear that bar. And additionally the sub zone to boss mapping is not unique in pratice nor in theory, so for that it would be a crutch.

And there are addons such as LoadoutReminder, which are exactly for that purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 Feature Request This is a request for a new feature, or an expansion of an existing feature.
Projects
None yet
Development

No branches or pull requests

2 participants