Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trigger support for softinteract #5560

Closed
gjfLeo opened this issue Nov 30, 2024 · 1 comment
Closed

Add trigger support for softinteract #5560

gjfLeo opened this issue Nov 30, 2024 · 1 comment
Labels
⏱ Awaiting Response This ticket hasn't been triaged yet. 🎨 Feature Request This is a request for a new feature, or an expansion of an existing feature.

Comments

@gjfLeo
Copy link

gjfLeo commented Nov 30, 2024

There's "Soft Enemy" and "Soft Friend" in unit info triggers. Can we support "softinteract" as well? It'll be useful when tracking cooldowns /items count related with GameObject, such as Overload Sporefused Herb.

Considering that the "softinteract" unit may be not a creature, maybe more works required?

@gjfLeo gjfLeo added the 🎨 Feature Request This is a request for a new feature, or an expansion of an existing feature. label Nov 30, 2024
@github-actions github-actions bot added the ⏱ Awaiting Response This ticket hasn't been triaged yet. label Nov 30, 2024
@emptyrivers
Copy link
Contributor

emptyrivers commented Dec 7, 2024

hmm, i wasn't convinced when i added softfriend/softenemy, and im still not convinced today. Like, I get the use case, i even made something similar myself, but I just don't see how select(6,UnitGUID("softinteract")) == "1337h4x0rz" is so broadly useful and/or annoying to implement in custom code to warrant supporting in the builtins.

Also as you mention, softinteract is usually going to be one GameObject or another, and most of the unit info triggers aren't able to glean interesting information about an object. That IMO kills the simple implementation ("just add Soft Interact to the Unit dropdown") on the grounds of "try to not accidentally lie to your users about what WeakAuras can do".

Did you have a use case in mind beyond just "is my soft interact target an herb i can overload"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⏱ Awaiting Response This ticket hasn't been triaged yet. 🎨 Feature Request This is a request for a new feature, or an expansion of an existing feature.
Projects
None yet
Development

No branches or pull requests

3 participants