Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cata Classic] summonPending prototype causing errors in many previously working auras #5580

Closed
1 task done
Road-block opened this issue Dec 12, 2024 · 4 comments · Fixed by #5583
Closed
1 task done
Assignees
Labels
⏱ Awaiting Response This ticket hasn't been triaged yet. 🐛 Bug This is a problem with WeakAuras.

Comments

@Road-block
Copy link
Contributor

Road-block commented Dec 12, 2024

Is there an existing issue for this?

  • I have searched the existing open and closed issues.

Description

Unexpected Lua errors in previously working auras upon updating the addon package to one of the latest alphas.

WeakAuras Version

5.18.0-22-g72d3da5 (alpha)

World of Warcraft Flavor

Cataclysm Classic

World of Warcraft Region

EU

Tested with only WeakAuras

I got this issue with only WeakAuras enabled

Lua Error

2x Lua error in aura 'command': Trigger 6
WeakAuras Version: 5.18.0-22-g72d3da5
Aura Version: 1.0.8
Stack trace:
[string ""]:17: attempt to index global 'C_IncomingSummon' (a nil value)
[string ""]:17: in function <[string ""]:4>
[string "=[C]"]: in function `xpcall'
[string "@WeakAuras/GenericTrigger.lua"]:720: in function <WeakAuras/GenericTrigger.lua:656>
[string "@WeakAuras/GenericTrigger.lua"]:966: in function `ScanEventsInternal'
[string "@WeakAuras/GenericTrigger.lua"]:903: in function `ScanEvents'
[string "@WeakAuras/GenericTrigger.lua"]:3838: in function <WeakAuras/GenericTrigger.lua:3832>
[string "=[C]"]: in function `CameraOrSelectOrMoveStop'
[string "CAMERAORSELECTORMOVE"]:4: in function <[string "CAMERAORSELECTORMOVE"]:1>

Locals:
state = <table> {
}
event = "UNIT_CHANGED_target"
unit = "target"
smart = false
extraUnit = ""
name = "Zerathuul"
realm = "PyrewoodVillage"
specificUnitCheck = true
unitisunit = false
class = "DRUID"
classification = "normal"
raidMarkIndex = 0
raidMark = ""
dead = false
resurrectPending = false
(*temporary) = nil
(*temporary) = false
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index global 'C_IncomingSummon' (a nil value)"

The in aura '<blah>' bit is irrelevant same error with a multitude of previously working auras

Reproduction Steps

  1. Error happens on load

Last Good Version

Before ca61475

Screenshots

No response

Export String

No response

Bisector Report

No response

@Road-block Road-block added the 🐛 Bug This is a problem with WeakAuras. label Dec 12, 2024
@github-actions github-actions bot added the ⏱ Awaiting Response This ticket hasn't been triaged yet. label Dec 12, 2024
@Road-block
Copy link
Contributor Author

Maybe this instead?

      {
        name = "summonPending",
        display = L["Summon Pending"],
        type = "tristate",
        width = WeakAuras.doubleWidth,
        init = WeakAuras.IsRetail() and "C_IncomingSummon.HasIncomingSummon(unit)" or nil,
        optional = true,
        enable = WeakAuras.IsRetail(),
        hidden = not WeakAuras.IsRetail(),
        store = true,
        conditionType = "bool",
      },

@Road-block
Copy link
Contributor Author

Oh
/dump C_EventUtils.IsEventValid("INCOMING_SUMMON_CHANGED") also returns false on Cataclysm Classic

@mrbuds
Copy link
Contributor

mrbuds commented Dec 12, 2024

If a function you call with custom code doesn't exists it's not a bug in WeakAuras

@mrbuds mrbuds closed this as completed Dec 12, 2024
@SpatenLa
Copy link

ca61475#diff-74981ab15c86143ed223f16f0262d7909123c141f07fa96bd3948b2981668720R2475
its a patch from rivers, in the alpha since yesterday

@mrbuds mrbuds reopened this Dec 12, 2024
@mrbuds mrbuds assigned mrbuds and emptyrivers and unassigned mrbuds Dec 12, 2024
emptyrivers added a commit to emptyrivers/WeakAuras2 that referenced this issue Dec 13, 2024
@mrbuds mrbuds closed this as completed in 3c64fcd Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⏱ Awaiting Response This ticket hasn't been triaged yet. 🐛 Bug This is a problem with WeakAuras.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants