Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Done" button in code editor throws error with specific custom code #5622

Closed
1 task done
Causese opened this issue Jan 17, 2025 · 1 comment
Closed
1 task done

"Done" button in code editor throws error with specific custom code #5622

Causese opened this issue Jan 17, 2025 · 1 comment
Labels
⏱ Awaiting Response This ticket hasn't been triaged yet. 🐛 Bug This is a problem with WeakAuras.

Comments

@Causese
Copy link
Contributor

Causese commented Jan 17, 2025

Is there an existing issue for this?

  • I have searched the existing open and closed issues.

Description

Certain code in the editor code causes the code editor's "Done" button to throw an error.
After reload it is no longer possible to open /wa

even /wa repair doesn't work

WeakAuras Version

5.18.0 / 5.18.1

World of Warcraft Flavor

Retail (Default)

World of Warcraft Region

EU

Tested with only WeakAuras

I got this issue with only WeakAuras enabled

Lua Error

two errors:

17x WeakAuras/GenericTrigger.lua:1055: attempt to compare number with string
[string "@WeakAuras/GenericTrigger.lua"]:1055: in function <WeakAuras/GenericTrigger.lua:1049>
[string "@WeakAuras/GenericTrigger.lua"]:1099: in function `CreateFakeStates'
[string "@WeakAuras/WeakAuras.lua"]:4678: in function `UpdateFakeStatesFor'
[string "@WeakAuras/WeakAuras.lua"]:4654: in function `FakeStatesFor'
[string "@WeakAuras/WeakAuras.lua"]:3268: in function <WeakAuras/WeakAuras.lua:3119>
[string "@WeakAuras/WeakAuras.lua"]:3292: in function <WeakAuras/WeakAuras.lua:3282>
[string "=[C]"]: in function `Add'
[string "@WeakAurasOptions/CommonOptions.lua"]:1630: in function <WeakAurasOptions/CommonOptions.lua:1621>
[string "=[C]"]: ?
[string "@Plater/libs/AceConfig-3.0-3/AceConfigDialog-3.0-87/AceConfigDialog-3.0.lua"]:45: in function <...nfig-3.0/AceConfigDialog-3.0/AceConfigDialog-3.0.lua:43>
[string "@Plater/libs/AceConfig-3.0-3/AceConfigDialog-3.0-87/AceConfigDialog-3.0.lua"]:839: in function <...nfig-3.0/AceConfigDialog-3.0/AceConfigDialog-3.0.lua:661>
[string "=[C]"]: ?
[string "@DevTool/Libs/AceGUI-3.0-41/AceGUI-3.0.lua"]:66: in function <DevTool/Libs/AceGUI-3.0/AceGUI-3.0.lua:64>
[string "@DevTool/Libs/AceGUI-3.0-41/AceGUI-3.0.lua"]:300: in function `Fire'
[string "@WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasMultiLineEditBox.lua"]:62: in function <...I-Widgets/AceGUIWidget-WeakAurasMultiLineEditBox.lua:59>

Locals:
data = <table> {
 outline = "OUTLINE"
 authorOptions = <table> {
 }
 displayText = "%p"
 shadowYOffset = -1
 anchorPoint = "CENTER"
 displayText_format_p_time_format = 0
 customTextUpdate = "event"
 automaticWidth = "Auto"
 actions = <table> {
 }
 triggers = <table> {
 }
 displayText_format_p_format = "timed"
 internalVersion = 78
 selfPoint = "BOTTOM"
 font = "Friz Quadrata TT"
 subRegions = <table> {
 }
 load = <table> {
 }
 fontSize = 12
 shadowXOffset = 1
 regionType = "text"
 displayText_format_p_time_legacy_floor = false
 displayText_format_p_time_mod_rate = true
 displayText_format_p_time_precision = 1
 displayText_format_p_time_dynamic_threshold = 60
 color = <table> {
 }
 justify = "LEFT"
 xOffset = 0
 id = "New"
 wordWrap = "WordWrap"
 frameStrata = 1
 anchorFrameType = "SCREEN"
 yOffset = 0
 uid = "WmkyrJRlVtN"
 fixedWidth = 200
 config = <table> {
 }
 shadowColor = <table> {
 }
 conditions = <table> {
 }
 information = <table> {
 }
 animation = <table> {
 }
}
triggernum = 2
state = <table> {
 total = ""
 index = ""
 progressType = "timed"
 changed = true
 expirationTime = ""
 show = true
 stacks = ""
 name = ""
 autoHide = false
 value = ""
 icon = ""
 duration = ""
}
eventData = <table> {
 statesParameter = "full"
 unit_events = <table> {
 }
 internal_events = <table> {
 }
 trigger = <table> {
 }
 event = "Health"
 events = <table> {
 }
 subevents = <table> {
 }
 force_events = "STATUS"
}
(*temporary) = ""
(*temporary) = 13676.070000
(*temporary) = 13676.070000
(*temporary) = "attempt to compare number with string"

1x WeakAuras/WeakAuras.lua:4752: attempt to perform arithmetic on local 'expirationTime' (a string value)
[string "@WeakAuras/WeakAuras.lua"]:4752: in function <WeakAuras/WeakAuras.lua:4704>
[string "@WeakAuras/WeakAuras.lua"]:4905: in function `UpdatedTriggerState'
[string "@WeakAuras/GenericTrigger.lua"]:1142: in function `ScanWithFakeEvent'
[string "@WeakAuras/GenericTrigger.lua"]:1475: in function `LoadDisplays'
[string "@WeakAuras/WeakAuras.lua"]:2027: in function `LoadDisplays'
[string "@WeakAuras/WeakAuras.lua"]:1808: in function <WeakAuras/WeakAuras.lua:1651>
[string "@WeakAuras/WeakAuras.lua"]:2004: in function `Resume'
[string "@WeakAuras/WeakAuras.lua"]:1293: in function <WeakAuras/WeakAuras.lua:1251>

[string "@WeakAuras/WeakAuras.lua"]:4525: in function `Immediate'
[string "@WeakAuras/WeakAuras.lua"]:1318: in function `Login'
[string "@WeakAuras/WeakAuras.lua"]:1393: in function <WeakAuras/WeakAuras.lua:1340>

Locals:
self = <table> {
 pools = <table> {
 }
 frame = Frame {
 }
 prios = <table> {
 }
 size = 1
}
name = "login"
func = <no value>
limit = 15000
defaultEstimate = 1000

Reproduction Steps

  1. Import WA
  2. expand trigger 1 code editor
  3. click done

Last Good Version

No response

Screenshots

No response

Export String

!WA:2!Lv1tVTrru84yKQ0k1QgtPIk1dwr0qlevfcQriK4G3u7MGCSDxVPnia5m7op7DiRNzzMzTDkId1N65CNl(mCXhG75tWkl(e0d8biFc4nZA7M6Uhw9MFV3mV)m)EVPqTs9lrlrFZdNWcf82IuziC)1KJA2TRc0fMsO)sQsd0JiJw)Dly81LNV0eEyKq2sW46G9R2WVQ3SqHiMkgYBpKLaNE5ILvP9GixJJoDSwY61dKQBTLCU4F7Qppbccrxi6)wvAama462PD7YgnTZ(vA73PTFfpFplEWbajwhT0UwsaTZRDRQ1RNDRrfODt5HAMG)qsCSst0GA7Ywl3UCNTltjAYJCkJFlv)JBU5px(7k)BwuZNksmeb0Yuy7LGHreEpG(b4jsrpjOu(yoGk3uZ6d0nFN(bK4uRIRHPfAs8ky0ujXe2RadJsy5k8XdEfLKuT4agf(GGIt(aBnv)vGW0p8m1Q2XPWORH972)sqNk5wV4aC6yvcehFiv54MYz6GKyY5G0lmccplBdpJ7votZVr7yUDNAl1Pjy5hMqHa8Y1uWKhuTERAhx)Iu(CYGtYge86Ba4NV(ibf(Z1Uc5yGKtIFbYCWAXFC1zaKubJIqTNP6eDbHZ6BRt75H(sQRDjquqBTe490r3i7MUCbhMTOmBJkPcWQcvn2yQjEY2YTpHXRL9aCdzBL95zpm7rzBf0LXzQOvHXerr0MdeIMG8rpOhEYQV9Uz3CgUmaRU9KIuo9n3jPKggP7OIiy)WjZ7GsUNf0(RRqIHFh1CHSTUyPUnFGk52xB77lIfYVVqHcfFBoke312f6w5y)MjFSf0qnm1JWxYO6i3k4YRYDeBeqTGVEwEh8pmpCU0Q30PZ6EE2nMifM7mFe0TrZgvZUPetkJntSggAdJI43fZZaUo521KSxv(5PekwviL99FVeFHNMzXgkK0xkjjJF5CH8ayatXcIHtNNZxBktYgh2OrvVoUn99BEK3Hp7a)zlDDB2RG7npJo598JrRLS18y)6h2O6)nRxSyynj8RPap88wF0opE3NKNDgfxA(9050KIJnRm7EwqQwl4nhasKSpXax3sT(KPg5fP2fMf7VS0CzQcE2cKiRLldo7jhXcpJJJpkA3y7qsmu01igzbQZqLBy9MlwLazuqeW6fPFTBSGqRfGdsWrB31RFASM54A6iUB2p54fgtukJKRclmgHKBJXsL5tYTd2JwfIXJMiTKyBZGJhjojIuC3ugD6jdAvPEYoF9Ep)ftz8CwkAOZBxmam)nKV4(RTUKyhaR2l7ZCY(shxS5r74(kHOFbV3XAMOfHdYBN)0c)1)SjJUBdy40UsC4b22I0NIjLW4B)5pIGtcWwD4uVHwY7v5x11mMBI2G277vTAJaSHUlRNJKXnhoeLCNfVczyYpLPii5IgndBqWT3mXgPotmZby5YJxSHtVyzRv2nkPcEYJ)QV5X7uAW)EY)p

Bisector Report


@Causese Causese added the 🐛 Bug This is a problem with WeakAuras. label Jan 17, 2025
@github-actions github-actions bot added the ⏱ Awaiting Response This ticket hasn't been triaged yet. label Jan 17, 2025
@Causese Causese changed the title Can't press "Done" in code editor "Done" button in code editor throws error with specific custom code Jan 17, 2025
@InfusOnWoW
Copy link
Contributor

I guess we need to make the code deal with:
expirationTime = ""

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⏱ Awaiting Response This ticket hasn't been triaged yet. 🐛 Bug This is a problem with WeakAuras.
Projects
None yet
Development

No branches or pull requests

2 participants