Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain accessible not in whitelist= #217

Open
gitdevmod opened this issue May 26, 2015 · 3 comments
Open

Domain accessible not in whitelist= #217

gitdevmod opened this issue May 26, 2015 · 3 comments

Comments

@gitdevmod
Copy link

Hi,

I've put "whitelist=www.cnil.fr" but at the top there is link to access g+, facebook, twitter, youtube. Theses link are like "http://www.cnil.fr/google/", http://www.cnil.fr/facebook/, http://www.cnil.fr/twitter/, http://www.cnil.fr/youtube/.
If I click on one of these links I can access to the page, for example youtube I can view videos.

Any ideas how to solve this issue ?

version : webconverger 28 amd64

@kaihendry
Copy link
Member

Hi! I think I see the problem with pref("extensions.webconverger.whitelist", "www.cnil.fr");...

I'm thinking why have you implemented those links as redirects on your homepage? If you do not want poeple to go on G+, FB, twitter or Youtube, why not update the social media bookmarks to go direct to those sites? Then they would fall outside the whitelist. 😃

Anything to add @mkaply ?

@gitdevmod
Copy link
Author

Hi kaihendry,

Because this is not my site :)

@mkaply
Copy link
Member

mkaply commented May 26, 2015

Well, even though the links are whitelisted, the pageloads themselves should fail because they are not on the whitelist. I'll have to check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants