Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deadlock detected DETAIL: Process 53 waits for ShareLock on transaction #13626

Closed
2 tasks done
tomkolp opened this issue Jan 22, 2025 · 9 comments
Closed
2 tasks done
Assignees
Labels
bug Something is broken.
Milestone

Comments

@tomkolp
Copy link
Contributor

tomkolp commented Jan 22, 2025

Describe the issue

Since version 5.10-0e03b03f41 , there is a problem with slow writing of strings. I get a lot of errors with the errors below. The errors should still be sent to sentry, so they can be analyzed.

deadlock detected
DETAIL:  Process 53 waits for ShareLock on transaction 9436782; blocked by process 48.
Process 48 waits for ShareLock on transaction 9436777; blocked by process 53.
HINT:  See server log for query details.
CONTEXT:  while locking tuple (88,104) in relation "trans_translation"

I already tried

  • I've read and searched the documentation.
  • I've searched for similar filed issues in this repository.

Steps to reproduce the behavior

Save translate.

Expected behavior

No response

Screenshots

No response

Exception traceback

How do you run Weblate?

Docker container

Weblate versions

Wersja Weblate 5.10-dev — 4490b12889d398c0989882dd14020c7bf0e6ca12

Weblate deploy checks

Additional context

No response

@nijel
Copy link
Member

nijel commented Jan 23, 2025

Do you know at which version was the last one before these errors appeared? I'm not aware of any recent change which could have caused that. Furthermore, when do you get these errors?

I've just realized that you were using the old Sentry server which we discarded a few months ago, so unfortunately we don't have these errors recorded…

nijel added a commit to nijel/weblate that referenced this issue Jan 23, 2025
This should make locking more straightforward to the server instead of
locking each row individually.

Fixes WEBLATE-20ZY
Fixes WEBLATE-15BD
Fixes WEBLATE-2101
Fixes WEBLATE-1MKN
Issue WeblateOrg#13626
@nijel
Copy link
Member

nijel commented Jan 23, 2025

#13632 should improve the situation if you observe this on uploading.

nijel added a commit that referenced this issue Jan 23, 2025
This should make locking more straightforward to the server instead of
locking each row individually.

Fixes WEBLATE-20ZY
Fixes WEBLATE-15BD
Fixes WEBLATE-2101
Fixes WEBLATE-1MKN
Issue #13626
@tomkolp
Copy link
Contributor Author

tomkolp commented Jan 24, 2025

I have uploaded the patch, after several hours of testing I have not received any errors via email.

Unfortunately, translation approvals are still very slow.

Can I get a new sentry address to send logs? If that is not possible, I will switch to my free sentry account and try to analyze it myself.
Edit:
However, the errors returned:
deadlock detected
DETAIL: Process 149 waits for ShareLock on transaction 9586553; blocked by process 599.
Process 599 waits for ShareLock on transaction 9586546; blocked by process 149.
HINT: See server log for query details.
CONTEXT: while locking tuple (63295,47) in relation "trans_unit"

@tomkolp
Copy link
Contributor Author

tomkolp commented Jan 25, 2025

@nijel
Copy link
Member

nijel commented Jan 27, 2025

The Sentry invitation didn't work:

Image

Can you please try resending it to [email protected]?

@tomkolp
Copy link
Contributor Author

tomkolp commented Jan 27, 2025

The Sentry invitation didn't work:

Image

Can you please try resending it to [email protected]?

I sent it

@tomkolp
Copy link
Contributor Author

tomkolp commented Jan 28, 2025

The last patch fixed the slow string saving issue.

Were you able to log into sentry? If so, I'll leave access for future bug analyses.

@nijel nijel added the bug Something is broken. label Jan 28, 2025
@nijel nijel self-assigned this Jan 28, 2025
@nijel nijel added this to the 5.10 milestone Jan 28, 2025
@nijel
Copy link
Member

nijel commented Jan 28, 2025

It again failed with the same error message. But looking inside Sentry, I got access to the project, so it did work in the end. I will keep an eye on the performance metrics there as your setup is quite specific.

Looking at the trace, this issue should be addressed by #13665.

@nijel nijel closed this as completed Jan 28, 2025
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken.
Projects
None yet
Development

No branches or pull requests

2 participants