Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create gh-pages (a website) where you can try out the extension without installing it #54

Open
WofWca opened this issue May 31, 2022 · 1 comment

Comments

@WofWca
Copy link
Owner

WofWca commented May 31, 2022

This is also helpful for people who are afraid (or other reasons) to install the extension (see #57).

Also need to consider making it an installable PWA, to play local (or non-local?) files.

Maybe also need to add a way to open non-local files in the local-file-player, with a link to the video file.

The biggest obstacle here is the usage of Web Extension API (e.g. browser.tabs.query(...).

Maybe we can add some ifs like (if (BUILD_DEFINITIONS.STANDALONE_DEMO_PAGE), so that Web Extension API is never used when the condition is true. So basically search for all the occurrences of browser..

I think we could utilize local-file-player and put popup in an <iframe>.

For popup, this may also help: https://github.com/WofWca/jumpcutter/compare/popup-separate-tab

@WofWca
Copy link
Owner Author

WofWca commented Aug 23, 2024

The simplest approach would be just to fork and make a barely working prototype at first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant