You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
// In case you coulnd't make it out. Practically turns on/off the extension. Why not actually turn it on/off?
// Because
// * We don't have such a hotkey action yet.
// * Hotkeys would also cease to work if we'd disable it.
// * It would create an audio glitch (at best), at worst it would remove/add audio delay (becaouse of how
// marginBefore) works.
// * It's computationally heavy.
// TODO these problems sound like then can be solved.
{
keyCombination: {code: 'KeyZ',},
action: HotkeyAction.TOGGLE_VOLUME_THRESHOLD,
actionArgument: 0,
},
{
keyCombination: {code: 'KeyZ',},
action: HotkeyAction.SET_SOUNDED_SPEED,
actionArgument: 1,
},
It's supposed to be like a quick extension toggle (without de(re)initialization). I personally set it to toggle both sounded speed and volume threshold, but the problem is if you decide to "switch off" the extension while the sounded speed is 1 alredy, it will toggle it to the previous value.
Best solution I can think of is to create a separate HotkeyAction for this instead of binding two actions (HotkeyAction.SET_SOUNDED_SPEED and HotkeyAction.TOGGLE_VOLUME_THRESHOLD) to the key.
The text was updated successfully, but these errors were encountered:
jumpcutter/src/settings/defaultSettings.ts
Lines 153 to 170 in 9374464
It's supposed to be like a quick extension toggle (without de(re)initialization). I personally set it to toggle both sounded speed and volume threshold, but the problem is if you decide to "switch off" the extension while the sounded speed is 1 alredy, it will toggle it to the previous value.
Best solution I can think of is to create a separate
HotkeyAction
for this instead of binding two actions (HotkeyAction.SET_SOUNDED_SPEED
andHotkeyAction.TOGGLE_VOLUME_THRESHOLD
) to the key.The text was updated successfully, but these errors were encountered: