Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: an option to not use the global "sounded speed" setting at all #79

Open
WofWca opened this issue Jul 10, 2022 · 0 comments
Open

Comments

@WofWca
Copy link
Owner

WofWca commented Jul 10, 2022

After 1c82c22 I thought that for some people it would be better if we did not attempt to change the default playback rate of media elements at all. For example, on one website they watch videos at 2.5x speed, on another it's 1.5x, but they want silence skipping to work on both of them. But currently our extension always sets sounded speed to the value stored in its settings, so if they visited the first website (where they watch at 2.5x), and then went to the second one (where they prefer to watch at 1.5x) – tough luck – our extension will set it to 2.5x.

I guess we could make the "sounded speed" setting not global but per-element. Also, maybe this should apply to "silence speed" as well? And other settings?

Also, how about instead of having such setting stored somewhere in the extension's code, we simply use el.defaultPlaybackRate is the value for it?

For this we can look up how the Video Speed Controller extension works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant