You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Maybe there are other problems related to this.
It should also prepare us for potentially attaching to several elements on the same document simultaneously.
IIRC the only benefit of using a shared one is performance. Not sure how bad creating several AudioContexts is, but I'm sure not super bad. But currently we only use one Controller at a time anyway, so it's not that we're gonna have a bunch of AudioContexts at simultaneously.
It used to be the case before fa678bf.
So I think we need to create a new one on each controller initialization.
The text was updated successfully, but these errors were encountered:
WofWca
changed the title
Use separate AudioContexts for each media element?
fix: use separate AudioContexts for each media element?
Jul 14, 2022
Using a shared one causes problems. See
jumpcutter/src/entry-points/content/StretchingController/StretchingController.ts
Lines 227 to 232 in 1c82c22
Maybe there are other problems related to this.
It should also prepare us for potentially attaching to several elements on the same document simultaneously.
IIRC the only benefit of using a shared one is performance. Not sure how bad creating several
AudioContext
s is, but I'm sure not super bad. But currently we only use one Controller at a time anyway, so it's not that we're gonna have a bunch ofAudioContext
s at simultaneously.It used to be the case before fa678bf.
So I think we need to create a new one on each controller initialization.
The text was updated successfully, but these errors were encountered: