Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better pitch-shifting (time-stretching) algorithm #81

Open
WofWca opened this issue Jul 14, 2022 · 0 comments
Open

Better pitch-shifting (time-stretching) algorithm #81

WofWca opened this issue Jul 14, 2022 · 0 comments

Comments

@WofWca
Copy link
Owner

WofWca commented Jul 14, 2022

It's what causes the distortion on marginBefore parts:

"message": "When it's currently silent and then we encounter a loud part, how many seconds prior to it we need to slow down (switch to sounded speed).\nThis is mostly to ensure that you can clearly hear the very first letters when someone begins to speak.\n\n⚠️ Note that non-zero values will cause audio DISTORTION when switching from silence to sounded speed AND will add constant audio DELAY equivalent to the value of this setting. These drawbacks do not apply if you use the \"experimental algorithm\"."

It's used in the StretchingController.
Our current one is a very simple one, it's not very good for speech if at all:

this.speedUpPitchShift = new PitchShift();
this.slowDownPitchShift = new PitchShift();

https://github.com/Tonejs/Tone.js/blob/389685c7ff6c2ced43105bf4f9b42d8c4b75158b/Tone/effect/PitchShift.ts#L22-L23

This is a blocker for #14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant