You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
You may say that It's kind of a non-normal thing that we switch to such high playback rate so maybe we shouldn't let other scripts notice that it's happening. Websites may watch 'ratechange' event and, for example, update user's website settings (playback rate), or something else.
The text was updated successfully, but these errors were encountered:
WofWca
changed the title
fix: prevent other (e.g. website) scripts from receiving 'ratechange' event when switching to silenceSpeed?
fix: prevent other (e.g. website, extensions) scripts from receiving 'ratechange' event when switching to silenceSpeed?
Jul 29, 2022
You may say that It's kind of a non-normal thing that we switch to such high playback rate so maybe we shouldn't let other scripts notice that it's happening. Websites may watch 'ratechange' event and, for example, update user's website settings (playback rate), or something else.
Note that this is not the same as
jumpcutter/src/entry-points/content/AllMediaElementsController.ts
Lines 584 to 599 in c63821f
because there we
.stopImmediatePropagation()
for allratechange
events, not just forsilenceSpeed
.It may help with compatibility with other playbackRate controlling extensions like "Video Speed Controller".
Not sure if we need this, need to know practical cases (besides maybe #25). Maybe make a per-site setting for this, idk.
To do this, look at
event.stopPropagation(
/event.stopImmediatePropagation(
and related stuff.Related #25
The text was updated successfully, but these errors were encountered: