Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug report - layout bug when editing Sensei course lessons #1016

Open
jonathanbossenger opened this issue Oct 12, 2022 · 4 comments
Open

Bug report - layout bug when editing Sensei course lessons #1016

jonathanbossenger opened this issue Oct 12, 2022 · 4 comments
Labels
[Component] Learn Theme Website development issues related to the Learn theme. [Type] Bug Something isn't working on the Learn website.

Comments

@jonathanbossenger
Copy link
Collaborator

jonathanbossenger commented Oct 12, 2022

Description

When editing a lesson in Sensei, there seems to be something causing the layout to break. I'm not sure if this is a Sensei issue, or a Learn WordPress issue.

Step-by-step reproduction instructions

  1. Edit a course
  2. Edit a lesson in a course
  3. View the layout for the lesson

Expected behaviour

I would expect the editor to display with the same "margins" as other content being edited

Actual behaviour

It does not have any of the spacing of other content being edited, and there appears to be a weird padding or layout element applied on the left of the menu

When I test this on a clean WordPress install with Sensei installed, this does not happen, so it looks like it's a Learn specific customisation that's caused this.

Screenshots or screen recording (optional)

SenseiLesson.mp4

Environment information

  • Brave
  • M1 MacBook Pro, with Monterey
@jonathanbossenger jonathanbossenger added [Type] Bug Something isn't working on the Learn website. Awaiting Triage Issues awaiting triage. See Training Team handbook for how to triage issues. labels Oct 12, 2022
@jonathanbossenger
Copy link
Collaborator Author

Additional screenshots

What I would expect (Editing a tutorial)

Edit-Tutorial-“Advanced-Layouts-with-the-Block-Editor”-‹-Learn-WordPress-—-WordPress

What I see editing a lesson

Edit-Lesson-“Creating-Custom-Templates-and-Template-Parts”-‹-Learn-WordPress-—-WordPress

@digitalchild
Copy link
Contributor

I can confirm that there is a padding issue while editing lessons.

Edit_Lesson_“What_Happens_When_Creating_and_Saving_Templates_Templates_Parts”_‹Learn_WordPress—_WordPress

@jonathanbossenger
Copy link
Collaborator Author

I can confirm that this doesn't happen on my current local version of the Learn code, which I last updated on 20 September (and is up to this commit) so something in the last month has caused this.

I'm going to try and incrementally pull by commit to my local to see if I can isolate where the change happened.

@kaitohm kaitohm removed the Awaiting Triage Issues awaiting triage. See Training Team handbook for how to triage issues. label Nov 9, 2022
@kaitohm kaitohm added the [Component] Learn Theme Website development issues related to the Learn theme. label Nov 9, 2022
@jonathanbossenger jonathanbossenger removed their assignment Nov 30, 2022
@BhargavBhandari90
Copy link

It has been long now. I tried to replicate this, but seems like this is also not a bug now.

https://go.screenpal.com/watch/cTeV6jn1Dbl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Learn Theme Website development issues related to the Learn theme. [Type] Bug Something isn't working on the Learn website.
Projects
Status: In Progress
Development

No branches or pull requests

4 participants