Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback - Content typos #2912

Closed
c-marc opened this issue Sep 27, 2024 · 4 comments
Closed

Feedback - Content typos #2912

c-marc opened this issue Sep 27, 2024 · 4 comments
Labels
Awaiting Triage Issues awaiting triage. See Training Team handbook for how to triage issues.

Comments

@c-marc
Copy link

c-marc commented Sep 27, 2024

Type of feedback

// content

Description

  • inconsistency in instructions: the example starts with a wideSize of 1280px, then 1200px twice, and finally gets back to 1280px
  • bad indentation of the final code: might confuse beginners who aren't familiar with JSON and/or code. Hierarchy would be clearer with proper indentation.

Step-by-step reproduction instructions (optional)

  1. https://learn.wordpress.org/lesson/your-first-codes-in-theme-json/
  2. In the "Layout" section, after the first screenshot that shows 1280px, 1200px is mentioned twice (in "Let's code..." and "Layout code reference"). This could be changed to 1280px to be consistent with previous and next content.
  3. At the bottom of the page, the full code has an incorrect indentation, starting from the second child of settings

Screenshots or screen recording (optional)

Other information (optional)

@c-marc c-marc added the Awaiting Triage Issues awaiting triage. See Training Team handbook for how to triage issues. label Sep 27, 2024
@github-project-automation github-project-automation bot moved this to Awaiting Validation in LearnWP Content - Feedback Oct 18, 2024
@benazeer-ben
Copy link

Feedback Validation Checklist:

  • If this is reporting an issue, can you confirm/reproduce the issue? Yes
  • What should happen next to apply the feedback?: In order to keep consistency in the instruction, use same wideSize value throughout the steps.
    Hierarchy should be clearer with proper indentation.

@Citrohead
Copy link

Working on this one

@Citrohead
Copy link

Fixed the mentioned typos and indentation issues.

@digitalchild
Copy link
Contributor

Thanks @Citrohead

@github-project-automation github-project-automation bot moved this from Awaiting Validation to Done in LearnWP Content - Feedback Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Triage Issues awaiting triage. See Training Team handbook for how to triage issues.
Projects
Development

No branches or pull requests

4 participants