You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The methods covered via the DecompressionTest test class need a lot more tests, in particular the Requests::compatible_gzinflate() method, which includes code paths currently completely untested and handling of ZIP file format, which when called from Requests::decompress() (which is the only way it is called from within the Requests library itself), can never be reached as the "magic markers" used by ZIP are not included in the Requests::$magic_compression_headers property.
A future iteration should do a more in-depth review of these two method to determine what should be handled by each method and add additional tests.
The text was updated successfully, but these errors were encountered:
The test cases in the DecompressionTest::dataDeflate() test look like the byte streams are messed. It looks like these are GZIP headers with ZLIB compressed data. This test scenario needs to be investigated, and this probably also means the code we currently have for decompression is not properly interpreting the headers.
As per #595:
The text was updated successfully, but these errors were encountered: