Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Theme Check plugin sometimes returns "Both DOS and UNIX style line endings" error #680

Closed
mikachan opened this issue Jul 2, 2024 · 2 comments · Fixed by #681
Closed
Labels
bug Something isn't working

Comments

@mikachan
Copy link
Member

mikachan commented Jul 2, 2024

In version 2.3.0, sometimes the Theme Check plugin returns the following error:

REQUIRED: Both DOS and UNIX style line endings were found in the file readme.txt. This causes a problem with SVN repositories and must be corrected before the theme can be accepted. Please change the file to use only one style of line endings.

This might be related to #662.

We might be able to fix this by using regex to normalise all new lines in the open text fields for the theme meta data.

To reproduce:

  • Update the font credits and manually add image credits using the CBT UI
  • Export the theme zip, install it on a local site, and run the Theme Check plugin
@matiasbenedetto
Copy link
Contributor

I don't this issue is directly related to #662
I think this problem could arise from any user input added to the readme.txt settings containing DOS style new line characters.

@matiasbenedetto
Copy link
Contributor

A potential fix for this issue: #681

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging a pull request may close this issue.

2 participants