Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Views: "Empty pattern" overlaps pattern name in table layout #68937

Open
3 of 6 tasks
carolinan opened this issue Jan 29, 2025 · 4 comments · May be fixed by #68997
Open
3 of 6 tasks

Data Views: "Empty pattern" overlaps pattern name in table layout #68937

carolinan opened this issue Jan 29, 2025 · 4 comments · May be fixed by #68997
Assignees
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@carolinan
Copy link
Contributor

Description

When viewing all patterns on Appearance > Editor > Patterns using the table layout, the text that explains that a pattern is empty overlaps the pattern name. This makes the text difficult to read.

  • I only tested with English, no translations.

Step-by-step reproduction instructions

Create a new empty pattern.
Go to Appearance > Editor > Patterns
Select the table layout.
Locate the pattern in the table. Confirm if the text overlaps.

Screenshots, screen recording, code snippet

The Pattern data view page with the table layout selected. The first pattern has overlapping text, making it difficult to read.

Environment info

No response

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes

Please confirm which theme type you used for testing.

  • Block
  • Classic
  • Hybrid (e.g. classic with theme.json)
  • Not sure
@carolinan carolinan added [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Bug An existing feature does not function as intended labels Jan 29, 2025
@t-hamano
Copy link
Contributor

Related: #59098

Instead of text, an icon or image that represents the "empty" state may be appropriate.

@dhruvang21
Copy link
Contributor

@t-hamano can we change css for the preview text by changing it to whitespace: wrap from nowrap

Image

@t-hamano
Copy link
Contributor

can we change css for the preview text by changing it to whitespace: wrap from nowrap

I think this approach is fine as a temporary solution for future improvements.

However, when this text is localized, it's not guaranteed that one word will fit on one line. I think it's necessary to test it in various languages.

@dhruvang21
Copy link
Contributor

@t-hamano, I agree with your thoughts that this can be used as a temporary fix. However, for the future, I suggest adding an icon that aligns with the design while also ensuring accessibility. It’s important to make sure that users can clearly understand the pattern, possibly through the icon itself.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants