Shadow Panel: Add reset button #68981
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
shail-mehta
added
[Type] Enhancement
| > .components-button.has-icon.has-text:first-child { | ||
| gap: $grid-unit-10; | ||
| } |
There was a problem hiding this comment.
CSS selectors with the .components- prefix should be avoided as much as possible. Can we use the HStack component inside the Button component as in the previous implementation?
| transition: opacity 0.1s ease-in-out; | ||
| @include reduce-motion("transition"); |
There was a problem hiding this comment.
| transition: opacity 0.1s ease-in-out; | |
| @include reduce-motion("transition"); | |
| @media not ( prefers-reduced-motion ) { | |
| transition: opacity 0.1s ease-in-out; | |
| } | |
See #68282
| 'block-editor-global-styles__shadow-editor__remove-button', | ||
| { 'is-open': isOpen } | ||
| ), | ||
| label: __( 'Remove shadow' ), |
There was a problem hiding this comment.
| label: __( 'Remove shadow' ), | |
| label: __( 'Reset' ), |
Keep wording consistent with other similar UI.
What, Why and How?
Closes #68973
This PR adds a reset button to the
Shadow Panel, which becomes visible on hover or focus.Testing Instructions
post editpage.Group blockand try changing the defaultshadow.resetbutton, which appears on hover.resetbutton and confirm the shadow gets reset.Screencast
shadow-demo.mov