add missing space before checked and remove outdated xhtml closing slash #8433
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| @@ -1183,7 +1183,7 @@ public function render_list_table_columns_preferences() { | |||
|
|
|||
| $id = "$column-hide"; | |||
| echo '<label>'; | |||
| echo '<input class="hide-column-tog" name="' . $id . '" type="checkbox" id="' . $id . '" value="' . $column . '"' . checked( ! in_array( $column, $hidden, true ), true, false ) . ' />'; | |||
| echo '<input class="hide-column-tog" name="' . $id . '" type="checkbox" id="' . $id . '" value="' . $column . '" ' . checked( ! in_array( $column, $hidden, true ), true, false ) . '>'; | |||
There was a problem hiding this comment.
| echo '<input class="hide-column-tog" name="' . $id . '" type="checkbox" id="' . $id . '" value="' . $column . '" ' . checked( ! in_array( $column, $hidden, true ), true, false ) . '>'; | |
| echo '<input class="hide-column-tog" name="' . $id . '" type="checkbox" id="' . $id . '" value="' . $column . '" ' . checked( ! in_array( $column, $hidden, true ), true, false ) . ' />'; |
I'd prefer to keep the self closing tag (<input /> rather than <input>)
There was a problem hiding this comment.
I'd prefer not to. This isn't valid HTML and a legacy leftover WP should finally get rid of - see Yoast/wordpress-seo#21858
There was a problem hiding this comment.
The legacy markup is still part of the HTML Coding Standards. The tags should keep the termination for now.
If/when the coding standards change, then the markup would be revised throughout the admin area.
|
Thanks @kkmuffme I added a small suggestion, but I'm going to commit it directly on svn |
Trac ticket: https://core.trac.wordpress.org/ticket/63037
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.