-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the post_exists query time during post import process. #162
Comments
This looks like a safe change, a few lines later where |
Thanks for checking this out @dd32 🙇 |
@dhusakovic You'll probably need to fork the repo |
Fixed by #163 |
During the post import we check whether the post already exists using post_exists.
The query currently utilises post title and date parameters, which will run through all the posts to try and find a match.
In cases where we have a large number of posts this query can time out and the import fail.
Passing the
post_type
topost_exists
function allows us to use thetype_status_date
key, which significantly drops the number of rows examined and the overall query time in certain instances.This change would also fix some edge case scenarios with posts across post types having the same title and date.
The update would be passing post_type argument to the check here:
https://github.com/WordPress/wordpress-importer/blob/master/src/class-wp-import.php#L659
So it would look like this
$post_exists = post_exists( $post['post_title'], '', $post['post_date'], $post['post_type'] );
The text was updated successfully, but these errors were encountered: