Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the post_exists query time during post import process. #162

Closed
dhusakovic opened this issue Apr 9, 2024 · 4 comments
Closed

Improve the post_exists query time during post import process. #162

dhusakovic opened this issue Apr 9, 2024 · 4 comments

Comments

@dhusakovic
Copy link
Contributor

During the post import we check whether the post already exists using post_exists.

The query currently utilises post title and date parameters, which will run through all the posts to try and find a match.

In cases where we have a large number of posts this query can time out and the import fail.

Passing the post_type to post_exists function allows us to use the type_status_date key, which significantly drops the number of rows examined and the overall query time in certain instances.

This change would also fix some edge case scenarios with posts across post types having the same title and date.

The update would be passing post_type argument to the check here:
https://github.com/WordPress/wordpress-importer/blob/master/src/class-wp-import.php#L659

So it would look like this
$post_exists = post_exists( $post['post_title'], '', $post['post_date'], $post['post_type'] );

@dd32
Copy link
Member

dd32 commented Apr 9, 2024

This looks like a safe change, a few lines later where $post_exists is used, the post_type is checked that it matches.. so querying only for that post_type shouldn't have any adverse effects.

@dhusakovic
Copy link
Contributor Author

Thanks for checking this out @dd32 🙇
What's the process for creating a PR to address the issue?
It looks like I don't have necessary access rights to push a branch up.

@rebeccahum
Copy link

@dhusakovic You'll probably need to fork the repo

@dd32
Copy link
Member

dd32 commented Oct 21, 2024

Fixed by #163

@dd32 dd32 closed this as completed Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants