Native vscode formatting + formatter performance #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked internals of formatting to better align to vscode's best practices. Also leverages some internal techniques to improve formatting performance
The result of this pr is a full file save format running in
~10ms
. This provides a much improved DX, similar to that of using the default dart format functionality. Example of this running is as follows:Screen.Recording.2025-02-09.at.6.48.05.PM.mov
Due to adhering to the
registerDocumentFormattingEditProvider
we're also able to tap into vscodes default formatting functionality. This means the "Format Document" action/hotkey should work out of the box (with eventual support for "format selection", and "format modified lines")Because of these changes, some configuration settings will need to be updated, and as such, this PR is a major. The changes to
settings.json
are as follows:Details
Relies on: https://github.com/Workiva/over_react_format/pull/152
CI QOL updates in dependabot, and assigning the new owners of @Workiva/fedx
Also closes Stop spamming output tab every time a file saves #23