Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate old ontologies #61

Open
BeckySharp opened this issue Mar 11, 2020 · 10 comments
Open

deprecate old ontologies #61

BeckySharp opened this issue Mar 11, 2020 · 10 comments
Assignees

Comments

@BeckySharp
Copy link
Collaborator

we should...

like the wm_with_flattened_interventions
and the old intervention one... etc

@chanys
Copy link
Collaborator

chanys commented Mar 12, 2020

@BeckySharp
Copy link
Collaborator Author

thanks!! @zupon any chance you can add it?
think we should delete the old ones or make a deprecated folder?

@BeckySharp
Copy link
Collaborator Author

greenhouse is present in https://github.com/WorldModelers/Ontologies/blob/master/feb2020_interventions.yml#L61 , but missing in https://github.com/WorldModelers/Ontologies/blob/master/wm_flat.yml

Otherwise, I think https://github.com/WorldModelers/Ontologies/blob/master/wm_with_flattened_interventions.yml is good for removal

thanks for checking things! I think this got missed, it is here:

@BeckySharp
Copy link
Collaborator Author

@kwalcock can you please add the functionality to export the wm_flat ontology?

@kwalcock
Copy link
Collaborator

Yes. There will be a PR with your name on it.

@chanys
Copy link
Collaborator

chanys commented Mar 12, 2020

The concept greenhouse is in wm_flat_metadata.yml , but not in wm_flat.yml

@BeckySharp
Copy link
Collaborator Author

Ah, gotcha! thanks! That's one of the problems with the strip_metadata script :(
the script should be redone or at least fixed, but it's been a back burner issue. but good catch, thanks! It's now fixed :)

@chanys
Copy link
Collaborator

chanys commented Mar 12, 2020

Yeah!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants