Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some feature requests #2

Open
JTF195 opened this issue Mar 12, 2021 · 5 comments
Open

Some feature requests #2

JTF195 opened this issue Mar 12, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@JTF195
Copy link

JTF195 commented Mar 12, 2021

Love your work so far. This is the best Valheim character editor yet

Some features I'd like to see, in no particular order:

  • Rearrange the order of skills
    For example, one of my characters has skills in this order: Run, Jump, Swim, ... etc
    Another character has Run, Clubs, Blocking, ... etc

  • Edit the Crafted By tag on an item
    Both when renaming a character (rename that character's crafted items too), and also just whenever

  • Compatibility with inventory size/slot mods
    Making changes with Loki currently deletes items equipped in EquipmentAndQuickSlots, and probably has similar interactions with other mods that extend the inventory size

  • Show the name of the character in the dropdown menu rather than the filename, and rename the file when renaming a character.

Edit: I just noticed these are already on your list:

  • Edit character stats (kills, deaths, crafts, builds)
    These stats are stored at the top of the character file, and are visible on the character select screen with the BetterUI mod
    The game currently doesn't increment the kill counter by default, but StatsLogger enables that

  • Clean up world map/explore/location data
    Each time a character joins a new world, it adds 4MB to the file size of the character.fch file.
    Would it be possible to prune old worlds?

@Wufflez
Copy link
Owner

Wufflez commented Mar 13, 2021

Hi, thanks for the suggestions - yes as you noticed, a few of those were already on my mind ha. At the moment the world data is just kinda skipped over as a black box, and put back exactly as it was. I do intend on making it so the user can inspect and even modoify that data too - as somebody else has asked if it's possible to set a custom spawn location which I'd guess is in those world data blobs.

My only concern, and I say this without even looking at the data once yet - is that there might not be an obvious way to identify each world for the user to select which ones to trim. The game serialises the world data as a dictionary where each world is looked up by a numeric 'world id' so hopefully there's something more useful inside the data itself I could display to the user. If not maybe just showing a preview of the map and fog of war thing, with the waypoints etc, would be enough for users to flick through them and quickly identify worlds that may not even exist any more. I guess it's easy enough to revert to a backup if you mess up and delete the wrong one.

I'll have to download those mods and see how they save the 'extra' slots. If it's a case of just saving items in positions outside the 8x4 grid then that'd be easy to detect and adjust the inventory view accordingly to match their inventory size. I'll download some of those mods and test to see how they work.

I'll admit, I've only got one character myself and hadn't thought about the order of the skills. The game likely saves the skills in the order you 'discover' them by doing actions so. I would imagine if I go and make a new character and only increase 2 or 3 skills then the file will only contain data for those skills too ha. Your point is very valid though, I will adjust it so they show up in the same order as the UI in-game for consistency.

@JTF195
Copy link
Author

JTF195 commented Mar 13, 2021

I will adjust it so they show up in the same order as the UI in-game for consistency.

They already do, fortunately. And I guess I didn't word that very well. I would actually like to edit the order the skills are stored in the file and displayed ingame

each world is looked up by a numeric 'world id' so hopefully there's something more useful inside the data itself I could display to the user

Maybe you could load the data from the locally stored worlds and cross reference those. That would at least let you trim out all of the worlds that aren't local

Some other crazy ideas, if you can figure out how to load worlds:

  • Repair all buildings (including the ones randomly generated in the world)
  • Edit the Crafted By tag on ALL items in the world
  • Reset terrain modifications
  • Reset boss death state / world "level"

@Wufflez
Copy link
Owner

Wufflez commented Mar 13, 2021 via email

@JTF195
Copy link
Author

JTF195 commented Mar 14, 2021

Do you think something like being able to drag and drop the skills into a new order would be fine?

Yup. That would be perfect

@JTF195
Copy link
Author

JTF195 commented Mar 15, 2021

Some more random ideas:

  • Character appearance previews
  • Edit Compendium entry unlocks
  • Edit trophy collection, "known" items, recipes, etc
  • Edit boss kill state (if that's stored in the character as well as on the world)
  • Edit misc statistics tracked by StatsLogger, besides the default ones
  • View/edit any other mods' information stored in the .fch file

More ideas for editing Worlds:

  • Delete player-created buildings
  • Delete auto-generated buildings (separately if possible)
  • Edit the number of days passed

@Wufflez Wufflez added the enhancement New feature or request label Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants