Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why you use 1088x640 instead of the original 1920x1080 for Tanks&Temples? #62

Closed
immortalCO opened this issue Nov 25, 2022 · 2 comments
Closed

Comments

@immortalCO
Copy link

Hi,

We evaluated your code on the Tanks&Temples dataset and found that the images outputted by your model have a size (resolution) of 1088x640‬, with a different ratio from the original image size of 1920x1080. It's also shown in your config file that you manually set it as 1088x640‬.

For Table 9 in your paper, you compared the results with NSVF, and the numbers of NSVF were the same as those in NSVF paper, which also claims that "The image resolution is 1920 × 1080" for Tanks&Temples.

Why did you choose the resolution of 1088x640? Were the metrics in Table 9 in your paper calculated with images with a resolution of 1088x640 or 1920x1080?

Thanks.

@Xharlie
Copy link
Owner

Xharlie commented Nov 26, 2022

Hi Jukun, we are using 1080Ti by the time and the memory is very small comparing with FB's clusters used by NSVF. 1088x640‬ is the largest limit my gpu can handle. If the resolution will affect number, I think I can make adjustment by isolating our results as a single table. If you want to compare with us, you can also downsample to 1088x640‬ both gt test view and the generated test view.

@Xharlie Xharlie closed this as completed Nov 26, 2022
@immortalCO
Copy link
Author

Thank you for your clarification! I fully understand that GPU memory is a very constraintful issue in this case.

Actually, I would suggest that instead of putting your results in a separate table, you could just upsample the 1088x640 output image to 1920x1080, so that it could be directly compared with the 1920x1080 ground truth, and the numbers and experiment settings will be then consistent with NSVF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants