From 715da0a50899a27294c10cba2f80375e28cca5e5 Mon Sep 17 00:00:00 2001
From: Jannis <jannis@jnns.de>
Date: Fri, 26 Jan 2024 22:09:27 +0100
Subject: [PATCH] refactoring

---
 .../AmeisenNavigation.Tester.csproj                |  4 ++++
 .../PublishProfiles/FolderProfile.pubxml           | 14 ++++++--------
 AmeisenNavigation/src/AmeisenNavigation.cpp        |  2 +-
 .../src/Smoothing/CatmullRomSpline.hpp             |  7 ++-----
 AmeisenNavigation/src/Utils/Path.hpp               |  2 ++
 5 files changed, 15 insertions(+), 14 deletions(-)

diff --git a/AmeisenNavigation.Tester/AmeisenNavigation.Tester.csproj b/AmeisenNavigation.Tester/AmeisenNavigation.Tester.csproj
index cbff3e1..6f3a1db 100644
--- a/AmeisenNavigation.Tester/AmeisenNavigation.Tester.csproj
+++ b/AmeisenNavigation.Tester/AmeisenNavigation.Tester.csproj
@@ -21,4 +21,8 @@
     <PackageReference Include="System.Drawing.Common" Version="8.0.0" />
   </ItemGroup>
 
+  <ItemGroup>
+    <Folder Include="Properties\PublishProfiles\" />
+  </ItemGroup>
+
 </Project>
diff --git a/AmeisenNavigation.Tester/Properties/PublishProfiles/FolderProfile.pubxml b/AmeisenNavigation.Tester/Properties/PublishProfiles/FolderProfile.pubxml
index 109a7dc..8699a5b 100644
--- a/AmeisenNavigation.Tester/Properties/PublishProfiles/FolderProfile.pubxml
+++ b/AmeisenNavigation.Tester/Properties/PublishProfiles/FolderProfile.pubxml
@@ -1,17 +1,15 @@
 <?xml version="1.0" encoding="utf-8"?>
 <!--
-https://go.microsoft.com/fwlink/?LinkID=208121. 
+https://go.microsoft.com/fwlink/?LinkID=208121.
 -->
-<Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+<Project>
   <PropertyGroup>
     <Configuration>Release</Configuration>
-    <Platform>x86</Platform>
-    <PublishDir>bin\Release\net5.0-windows\publish\</PublishDir>
+    <Platform>Any CPU</Platform>
+    <PublishDir>bin\Release\net8.0-windows7.0\publish\</PublishDir>
     <PublishProtocol>FileSystem</PublishProtocol>
-    <TargetFramework>net5.0-windows</TargetFramework>
-    <RuntimeIdentifier>win-x86</RuntimeIdentifier>
+    <_TargetId>Folder</_TargetId>
+    <TargetFramework>net8.0-windows7.0</TargetFramework>
     <SelfContained>false</SelfContained>
-    <PublishSingleFile>True</PublishSingleFile>
-    <PublishReadyToRun>False</PublishReadyToRun>
   </PropertyGroup>
 </Project>
\ No newline at end of file
diff --git a/AmeisenNavigation/src/AmeisenNavigation.cpp b/AmeisenNavigation/src/AmeisenNavigation.cpp
index 2f1a70d..711721e 100644
--- a/AmeisenNavigation/src/AmeisenNavigation.cpp
+++ b/AmeisenNavigation/src/AmeisenNavigation.cpp
@@ -455,7 +455,7 @@ bool AmeisenNavigation::TryGetClientAndQuery(size_t clientId, int mapId, Ameisen
     if (!IsValidClient(clientId)) { return false; }
 
     client = Clients.at(clientId);
-    auto& format = client->GetMmapFormat();
+    auto format = client->GetMmapFormat();
 
     // we already have a query
     if (query = client->GetNavmeshQuery(mapId)) { return true; }
diff --git a/AmeisenNavigation/src/Smoothing/CatmullRomSpline.hpp b/AmeisenNavigation/src/Smoothing/CatmullRomSpline.hpp
index b504c27..a9fb129 100644
--- a/AmeisenNavigation/src/Smoothing/CatmullRomSpline.hpp
+++ b/AmeisenNavigation/src/Smoothing/CatmullRomSpline.hpp
@@ -46,12 +46,9 @@ namespace CatmullRomSpline
 
                 ScaleAndAddVector3(B1, (t2 - t) / (t2 - t1), B2, (t - t1) / (t2 - t1), C);
 
-                if (!std::isnan(C.x) && !std::isnan(C.y) && !std::isnan(C.z))
-                {
-                    if (*outputSize > maxIndex) { return; }
+                InsertVector3(output, *outputSize, &C, 0);
 
-                    InsertVector3(output, *outputSize, &C, 0);
-                }
+                if (*outputSize > outputMaxSize - 1) { return; }
             }
         }
     }
diff --git a/AmeisenNavigation/src/Utils/Path.hpp b/AmeisenNavigation/src/Utils/Path.hpp
index 0c17ebe..fd73d9c 100644
--- a/AmeisenNavigation/src/Utils/Path.hpp
+++ b/AmeisenNavigation/src/Utils/Path.hpp
@@ -21,7 +21,9 @@ struct Path
     {}
 
     constexpr inline auto& operator[](int i) noexcept { return points[i]; }
+
     constexpr inline Vector3* begin() const noexcept { return points; }
     constexpr inline Vector3* end() const noexcept { return points + pointCount; }
+
     constexpr inline int GetSpace() const noexcept { return maxSize - pointCount; }
 };