Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

self.group_size*2 should be self.group_size in prepare_data() #39

Open
eri24816 opened this issue Nov 19, 2022 · 0 comments
Open

self.group_size*2 should be self.group_size in prepare_data() #39

eri24816 opened this issue Nov 19, 2022 · 0 comments

Comments

@eri24816
Copy link

Thank you for providing the code for finetuning the model on custom midi datasets!

I notice that at the line 251 in model.py, the "step" argument of np.arrage is set to self.group_size*2. I think it leads to skipping half of the segments in pairs. Should it be just self.group_size instead of self.group_size*2?

for i in np.arange(0, len(pairs)-self.group_size, self.group_size*2):
    data = pairs[i:i+self.group_size]
        if len(data) == self.group_size:
             segments.append(data)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant