From 4e2896b03f32ca15bc1472ee98f2b9d7a8ccdc83 Mon Sep 17 00:00:00 2001 From: Yvan Duhamel Date: Mon, 15 Apr 2024 09:53:43 +0200 Subject: [PATCH] Ignore case when comparing claim types (#205) * ignore case when comparing claim types * Update CHANGELOG.md * Update CHANGELOG.md --- CHANGELOG.md | 3 ++- .../Configuration/LDAPProviderConfiguration.cs | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c137bbb..334e73d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,11 +2,12 @@ ## Unreleased +* Fix error when creating the configuration, due to case-sensitive test in the claim types - https://github.com/Yvand/LDAPCP/issues/204 * Fix the error when loading the global configuration page, if the group claim type set in the LDAPCP configuration does not exist in the trust. https://github.com/Yvand/LDAPCP/issues/203 ## LDAPCP Second Edition v17.0.20240226.2 - Published in February 26, 2024 -* Initial release of LDAPCP Second Edition, a complete rewrite of current project +* Ignore case when comparing claim types, to avoid errors when creating the configuration - https://github.com/Yvand/LDAPCP/pull/205 ## LDAPCP v16.0.20230824.1 enhancements & bug-fixes - Published in August 24, 2023 diff --git a/Yvand.LDAPCPSE/Yvand.LdapClaimsProvider/Configuration/LDAPProviderConfiguration.cs b/Yvand.LDAPCPSE/Yvand.LdapClaimsProvider/Configuration/LDAPProviderConfiguration.cs index 9c80646..3eaa8e0 100644 --- a/Yvand.LDAPCPSE/Yvand.LdapClaimsProvider/Configuration/LDAPProviderConfiguration.cs +++ b/Yvand.LDAPCPSE/Yvand.LdapClaimsProvider/Configuration/LDAPProviderConfiguration.cs @@ -141,7 +141,7 @@ public static ClaimTypeConfigCollection ReturnDefaultClaimTypesConfig(string cla //// Not adding those as additional attributes to avoid having too many LDAP attributes to search users in the LDAP filter - var nonIdentityClaimTypes = ClaimsProviderConstants.GetDefaultSettingsPerUserClaimType().Where(x => x.Key != spTrust.IdentityClaimTypeInformation.MappedClaimType); + var nonIdentityClaimTypes = ClaimsProviderConstants.GetDefaultSettingsPerUserClaimType().Where(x => !String.Equals(x.Key, spTrust.IdentityClaimTypeInformation.MappedClaimType, StringComparison.OrdinalIgnoreCase)); foreach (var nonIdentityClaimType in nonIdentityClaimTypes) { ctConfig = nonIdentityClaimType.Value;