Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting meta information based on particular selectors #45

Closed
ghost opened this issue Feb 13, 2017 · 6 comments
Closed

Selecting meta information based on particular selectors #45

ghost opened this issue Feb 13, 2017 · 6 comments

Comments

@ghost
Copy link

ghost commented Feb 13, 2017

Hey, thank you for your great, great tool. I use it a lot for reading!

Especially on Wikipedia, which is why I thought of a suggestion. Now, on *.wikipedia.org/* the date and author are not set:

image

However, reviewing the source learns that the date is set in ID footer-info-lastmod:

image

And the author is of course Wikipedia, but could be read from ID siteSub too, so it would be translated on Wikipedia sites in other languages:
image

I could try to find a way in JS to get those values from those ID's, if you would like. Or is there another solution?

@ZachSaucier
Copy link
Owner

Searching for specific IDs on a site-by-site basis in order to find meta information like date and author (or page content for that matter) would lead to a crap ton of selector searching every time Just Read is ran. As such, I won't be implementing any such selector searching other than what I currently have (or something similar) which checks for things called "author", "date", etc. If a site doesn't use something reasonable then Just Read won't be able to find it. The only real way to do this would be to use some AI and parse all the text on a page to try and determine it, which is a bit out of scope for Just Read at least at this point in time.

You can always edit this information yourself by hovering over it and clicking the pencil that appears. You could also write a userscript to automatically change this information on Wikipedia if you read those pages regularly.

P.S. Your theme looks great! You should share it with people on the theme sharing post.

@ghost
Copy link
Author

ghost commented Feb 13, 2017

Right, thanks 👍

I altered your JS to add 10 lines of code. Now, Wikipedia looks great. There's one thing I think you should change. But I'll put it in a Pull Request.

Thanks for the great extension!

@ghost
Copy link
Author

ghost commented Feb 13, 2017

I do like an option in the settings where one can set an ID or class for a date, author or title per web address 😄 😄

See this as an extension on your extension then 😉

@ZachSaucier
Copy link
Owner

ZachSaucier commented Feb 13, 2017

That's not a bad idea. I'll add it to my list of things to investigate more deeply

@ZachSaucier ZachSaucier reopened this Feb 13, 2017
@ZachSaucier ZachSaucier changed the title Date and author on Wikipedia Selecting meta information based on particular selectors Feb 13, 2017
@ghost
Copy link
Author

ghost commented Feb 13, 2017

Thanks. Wikipedia is still the 6th website in the global Alexa Top 500 and solely used for article reading, so I think it couldn't hurt adding some code to optimize the view of the most visited article website ever. But user options that allow such would be great too 👍

@ZachSaucier
Copy link
Owner

This is now supported in the premium version of Just Read! See this post for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant