frost-client: add trusted-dealer warnings #486
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #472
We do not address the finding directly. Rationale:
As it stands, we believe the suggested check wouldn't be meaningful. Only after receiving the config files would the participants need to verify the commitments, which happens outside of the tool; additionally, that requires the commitments which are not stored in the config file. We believe it also does not make sense to include the check for reference because that requires a broadcast channel which is complicated to setup. We decided to instead add warnings on the command line help and in the source code.