Suggestion 3: Rename Functions and Variables in Participants and Coordinator for Improved Clarity

[mpguerra]

Location

participant/src/cli.rs#L27

Synopsis

Certain functions and variable names are not intuitive and decrease the readability of the code. This includes, in particular, the functions responsible for the signing protocol on both the participant and coordinator side. The participant side progresses in rounds (1 and 2), while the coordinator progresses in steps (1, 2, and 3). However, the connection between the two communicating parties is not immediately clear. In addition, the function get_signature_shares called by the coordinator first sends signing packages and then receives signature shares in the second step.

Mitigation

We suggest unifying the rounds and steps into one consistent setup for the coordinator and participant. We additionally recommend renaming the function get_signature_shares to send_signing_packages_and_get_signature_shares or a similar alternative.