Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frostd, dkg, coordinator: check msg size; cleanup on error #493

Open
wants to merge 1 commit into
base: validate-send-receive
Choose a base branch
from

Conversation

conradoplg
Copy link
Contributor

Based on #485

Closes #480.

The issue is not addressed directly as suggested; rationale:

FROST is not a robust protocol, meaning participants can always prevent a signing sessions from succeeding. For this reason, we don't actively try to prevent participants from being able to abort sessions; they can do that in a myriad of different ways like sending a invalid encrypted message. That being said, we did add a message limit check on the server to mitigate memory exhaustion (since otherwise the length would only be checked when someone receives and decrypts a message). We also added session cleanup in case of error for coordinator and DKG starter, to avoid having aborted sessions lingering in case of error during the protocol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion 5: Improve Handling of Excessively Large Messages During Encryption / Decryption
1 participant