Suggestion 7: Improve HTTP Error Handling

[mpguerra]

Location

src/comms/http.rs#L496

Synopsis

In the following lines of code, _r is not checked. Consequently, if the server responds with HTTP 400 or 500, the code will not detect it:

let _r = self.client
    .post(format!("{}/send", self.host_port)) 
    .json(&frostd::SendArgs { ... }) 
    .send().await?;

Mitigation

One possible solution could be to implement the following:

let resp = self.client.post(...).send().await?; 
if !resp.status().is_success() { 
    return Err(eyre!("send failed: {}", resp.status()).into()); 
}