Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity & Payment/Invoice view: How to round and display amounts/fees? #2786

Open
myxmaster opened this issue Jan 31, 2025 · 1 comment
Open

Comments

@myxmaster
Copy link
Contributor

Describe your enhancement idea

Right now we are displaying amounts and fees in both views, Activity and Payment/Invoice details, by simply cutting off decimal places. We only use exact numbers (msat precision) in Payment Path view.

Activity:
Image

Image Image

My suggestion:
For Activity view:

  • if something was rounded, make that clear by displaying "~" char (e.g. 1,235 sats + ~1 sat fee)
  • use correct rounding (round up as of x.5, otherwise down)

For Payment/Invoice view:

  • display exact numbers since we have more than enough real estate here
    -> in the end this is our "detailed" view and it should be precise, while the payment path view has a specific purpose but shouldn't be the only place where user can get exact numbers.
@myxmaster
Copy link
Contributor Author

And: For any numbers denominated in fiat we can drop the "~" char, because everybody knows it is an approximation anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant