Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code needs some cleaning to improve readability #68

Open
Ragarnoy opened this issue Mar 19, 2021 · 0 comments
Open

Code needs some cleaning to improve readability #68

Ragarnoy opened this issue Mar 19, 2021 · 0 comments
Assignees
@Ragarnoy @demonoidv
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@Ragarnoy
Copy link
Collaborator

  • compute_and_set_fscore (and compute_score) depend on Algorithm, but they only use self.patterns and have no other interactions with Algorithm and they take a mutable reference on Node. Shouldn't they depend on Node instead ?
  • Literally the same issue with node_generator and get_potential_moves
  • Algorithm::patterns should be moved elsewhere or something
  • Fscore (concept) should be in Node and not Goban for obvious reasons
  • compute_score is just too long and could be split in many functions
  • Fscore (struct) is obsolete?
@Ragarnoy Ragarnoy added bug Something isn't working help wanted Extra attention is needed labels Mar 19, 2021
@Ragarnoy Ragarnoy changed the title Code has code smell and needs to be cleansed Fix code smell and needs to be cleansed Mar 19, 2021
@Ragarnoy Ragarnoy changed the title Fix code smell and needs to be cleansed Code needs some cleaning to improve readability Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ragarnoy Ragarnoy

@demonoidv demonoidv

Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ragarnoy @demonoidv