Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profit margin #36

Open
calamarcus opened this issue May 23, 2021 · 8 comments
Open

Profit margin #36

calamarcus opened this issue May 23, 2021 · 8 comments

Comments

@calamarcus
Copy link

Hi again. How is the profit function work. i went live on a pump and put 0.5 profit in the config. i finished woth a profit, but at 8%, so im eager to learn how the bot works in regards to getting the most profit.

@nikeboy264
Copy link

nikeboy264 commented May 23, 2021

There are 2 reasons:

  1. The bot buy/sell using market order, not limit. (The market price when you sell always less than or equal avg price)
  2. Because sell using market order, so the bot keep checking current avg price, if it reaches the profit then the bot sell the coin (it take a little time from 'check' to 'sell'). In a pump game, the avg price up/down very quick, so at the time that the avg price reaches the profit, then maybe at the moment the bot does sell, the avg price goes down.

@calamarcus
Copy link
Author

Okay. That is not good. An improved solution might be needed.

@abayomi185
Copy link
Owner

Hi @nikeboy264 you seem knowledgeable on this. Would it be beneficial to to be able to make limit sell order too? Or would that be too risky when selling?

@rishabhkr432
Copy link

rishabhkr432 commented May 25, 2021

I have a basic algorithm, I hope this helps.
2. Set a limit-sell at the start.
3. Store the clientOid or orderID
4. Check if limit-sell is filled or not using isActive in Data dict.

image

  1. If limit-sell is not filled within the set time then cancel the limit order using the stored orderID and create a new market sell order.

@nikeboy264
Copy link

Hi @nikeboy264 you seem knowledgeable on this. Would it be beneficial to to be able to make limit sell order too? Or would that be too risky when selling?

I agree with @rishabhkr432's solution.
To lower the risk and more advanced, i think:

  1. Buy the coin with Market order. Timer to sell fallback now activated.

  2. Split the coin qty to 4 parts. (E.g bot was bought 100 BTC)

  3. Set the profit expected for each part (in configuration file). E.g:
    1st 25BTC - Profit margin: 10%
    2nd 25BTC - Profit margin: 20%
    3rd 25BTC - Profit margin: 50%
    4th 25BTC - Profit margin: 80%

  4. Place 4 sell orders using Limit order. Limit order is the best because when the coin price reach profit expected, the coin will be sold immediately.

  5. I think the bot no need to waste time to check if the Limit sell order is filled. If Timer (in step 1) is end, the bot cancelled all available Limit Sell order and do sell fallback.

@rishabhkr432
Copy link

Hi @nikeboy264 you seem knowledgeable on this. Would it be beneficial to to be able to make limit sell order too? Or would that be too risky when selling?

I agree with @rishabhkr432's solution.
To lower the risk and more advanced, i think:

  1. Buy the coin with Market order. Timer to sell fallback now activated.
  2. Split the coin qty to 4 parts. (E.g bot was bought 100 BTC)
  3. Set the profit expected for each part (in configuration file). E.g:
    1st 25BTC - Profit margin: 10%
    2nd 25BTC - Profit margin: 20%
    3rd 25BTC - Profit margin: 50%
    4th 25BTC - Profit margin: 80%
  4. Place 4 sell orders using Limit order. Limit order is the best because when the coin price reach profit expected, the coin will be sold immediately.
  5. I think the bot no need to waste time to check if the Limit sell order is filled. If Timer (in step 1) is end, the bot cancelled all available Limit Sell order and do sell fallback.

Yeah, this sounds more reasonable. Checking limit-sell again would be time-consuming.

@ghost
Copy link

ghost commented May 26, 2021

What is the best settings for huge pumps like 1000% ?

@rishabhkr432
Copy link

rishabhkr432 commented May 26, 2021

Lol bruh your expectations seem to be really high. Calm down.
Also I replied to you in the other issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants