Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding circuits are incorrect #2

Open
abdullahkhalids opened this issue Feb 4, 2024 · 2 comments · Fixed by #3
Open

Encoding circuits are incorrect #2

abdullahkhalids opened this issue Feb 4, 2024 · 2 comments · Fixed by #3

Comments

@abdullahkhalids
Copy link
Owner

I received a bug report in an email that I am pasting here

Here is the issue I've encountered. I'm using stac to find logical states given a set of stabilizer generators and have noticed some discrepancies between the logical states found by stac and my own implementation. To test which was correct I checked if the output set of logical states was correctly stabilized and I saw that using stac many states are not stabilized.

I created a collab notebook https://colab.research.google.com/drive/1GcqFy1fkYJTw4tVKU8Vg4WcAHUZYcXGD?usp=sharing with a simple set of experiments for several codes.
Stac does work work some codes but fails for others. I thought you would like to know in case there may be a bug in your encoding circuit. Please let me know what you think and if you end up finding any bugs.

@manuelgpda
Copy link
Contributor

When I run the collab notebook in https://colab.research.google.com/drive/1GcqFy1fkYJTw4tVKU8Vg4WcAHUZYcXGD?usp=sharing I do not obtain ´Passed´ in all the tests so I am not sure that #3 fixed #2 .

@abdullahkhalids
Copy link
Owner Author

You are correct. I mindlessly accepted the pull request. I will take a look at this soon, and figure out what's wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants