Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving the extension methods on AblySdkRealtime* contained in DefaultAbly.kt #870

Open
lawrence-forooghian opened this issue Dec 29, 2022 · 1 comment

Comments

@lawrence-forooghian
Copy link
Collaborator

From @KacperKluka in #868 (comment):

The point of using extension functions is to extend the functionality of objects you can't control. However, right now we have control over the AblySDKRealtime interface so instead of using an extension function we can simply add the closeSuspending() method to the interface 🤔 But this is not critical, so feel free to do it as a part of this PR or create an issue for changing it later 😉

My reply:

I think that if we're going to move those to non-private functions then we need to add tests for them. Currently, their functionality will be tested as part of the tests proposed for DefaultAbly in #869. But if we move this functionality out of the DefaultAbly class this will no longer be the case.

@sync-by-unito
Copy link

sync-by-unito bot commented Dec 29, 2022

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant