Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log ConnectionExceptions with status codes other than 4xx or 5xx #931

Open
KacperKluka opened this issue Jan 23, 2023 · 1 comment
Open

Log ConnectionExceptions with status codes other than 4xx or 5xx #931

KacperKluka opened this issue Jan 23, 2023 · 1 comment
Labels
enhancement New feature or improved functionality.

Comments

@KacperKluka
Copy link
Contributor

Now, there are a lot of places in which we create the ConnectionException and in the future, there will be even more places. Therefore, in order to log all exceptions that have the statusCode set to something else than 4xx or 5xx we should think about some kind of an interceptor that would be launched each time a ConnectionException is created.

I don't think there's any case that's not a 4xx or a 5xx. I think I'd prefer that there's an error logged in that case - even if statusCode == 0.

Originally posted by @paddybyers in #929 (comment)
@KacperKluka KacperKluka added the enhancement New feature or improved functionality. label Jan 23, 2023
@KacperKluka KacperKluka mentioned this issue Jan 23, 2023
Merged
@sync-by-unito
Copy link

sync-by-unito bot commented Feb 16, 2023

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or improved functionality.
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KacperKluka