From 65b7da13bf05228cfffc0db7c72f8343866b9c57 Mon Sep 17 00:00:00 2001 From: Laramie Leavitt Date: Tue, 7 Jan 2025 15:41:04 -0800 Subject: [PATCH] Minor include cleanup in absl/random/internal PiperOrigin-RevId: 713065097 Change-Id: Ic89ca57a0f2882c61151c23281843041fdc99fb3 --- absl/random/CMakeLists.txt | 4 ++-- absl/random/internal/BUILD.bazel | 4 ++-- absl/random/internal/distribution_test_util.h | 6 +++--- absl/random/internal/iostream_state_saver.h | 7 +++++-- absl/random/internal/nonsecure_base_test.cc | 11 ++++++----- 5 files changed, 18 insertions(+), 14 deletions(-) diff --git a/absl/random/CMakeLists.txt b/absl/random/CMakeLists.txt index 1d8464be97b..6d18b9d7ae5 100644 --- a/absl/random/CMakeLists.txt +++ b/absl/random/CMakeLists.txt @@ -675,6 +675,7 @@ absl_cc_library( LINKOPTS ${ABSL_DEFAULT_LINKOPTS} DEPS + absl::config absl::int128 absl::type_traits ) @@ -1034,8 +1035,7 @@ absl_cc_test( absl::random_internal_nonsecure_base absl::random_random absl::random_distributions - absl::random_seed_sequences - absl::strings + absl::type_traits GTest::gtest_main ) diff --git a/absl/random/internal/BUILD.bazel b/absl/random/internal/BUILD.bazel index 21b324f018b..7093e472baa 100644 --- a/absl/random/internal/BUILD.bazel +++ b/absl/random/internal/BUILD.bazel @@ -249,6 +249,7 @@ cc_library( copts = ABSL_DEFAULT_COPTS, linkopts = ABSL_DEFAULT_LINKOPTS, deps = [ + "//absl/base:config", "//absl/meta:type_traits", "//absl/numeric:int128", ], @@ -621,10 +622,9 @@ cc_test( linkopts = ABSL_DEFAULT_LINKOPTS, deps = [ ":nonsecure_base", + "//absl/meta:type_traits", "//absl/random", "//absl/random:distributions", - "//absl/random:seed_sequences", - "//absl/strings", "@googletest//:gtest", "@googletest//:gtest_main", ], diff --git a/absl/random/internal/distribution_test_util.h b/absl/random/internal/distribution_test_util.h index 6d94cf6c97b..1189340e3a7 100644 --- a/absl/random/internal/distribution_test_util.h +++ b/absl/random/internal/distribution_test_util.h @@ -16,9 +16,9 @@ #define ABSL_RANDOM_INTERNAL_DISTRIBUTION_TEST_UTIL_H_ #include -#include -#include +#include +#include "absl/base/config.h" #include "absl/strings/string_view.h" #include "absl/types/span.h" @@ -96,7 +96,7 @@ double BetaIncomplete(double x, double p, double q); // https://www.jstor.org/stable/2346798 // https://www.jstor.org/stable/2346887 // -// BetaIncompleteInv(p, q, beta, alhpa) +// BetaIncompleteInv(p, q, beta, alpha) // `p` is beta parameter p, `q` is beta parameter q. // `alpha` is the value of the lower tail area. // diff --git a/absl/random/internal/iostream_state_saver.h b/absl/random/internal/iostream_state_saver.h index e6e242ee1e6..0f56bcb8346 100644 --- a/absl/random/internal/iostream_state_saver.h +++ b/absl/random/internal/iostream_state_saver.h @@ -16,10 +16,14 @@ #define ABSL_RANDOM_INTERNAL_IOSTREAM_STATE_SAVER_H_ #include -#include +#include +#include +#include #include +#include #include +#include "absl/base/config.h" #include "absl/meta/type_traits.h" #include "absl/numeric/int128.h" @@ -95,7 +99,6 @@ typename absl::enable_if_t::value, null_state_saver> make_ostream_state_saver(T& is, // NOLINT(runtime/references) std::ios_base::fmtflags flags = std::ios_base::dec) { - std::cerr << "null_state_saver"; using result_type = null_state_saver; return result_type(is, flags); } diff --git a/absl/random/internal/nonsecure_base_test.cc b/absl/random/internal/nonsecure_base_test.cc index 3502243e151..78eea8e3f9a 100644 --- a/absl/random/internal/nonsecure_base_test.cc +++ b/absl/random/internal/nonsecure_base_test.cc @@ -14,17 +14,18 @@ #include "absl/random/internal/nonsecure_base.h" -#include +#include #include -#include -#include +#include #include -#include +#include +#include +#include #include "gtest/gtest.h" +#include "absl/meta/type_traits.h" #include "absl/random/distributions.h" #include "absl/random/random.h" -#include "absl/strings/str_cat.h" namespace {