Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please remove dependencies on **rgdal**, **rgeos**, and/or **maptools** #68

Closed
rsbivand opened this issue Dec 14, 2022 · 6 comments
Closed

Comments

@rsbivand
Copy link

This package depends on (depends, imports or suggests) raster and one or more of the retiring packages rgdal, rgeos or maptools (https://r-spatial.org/r/2022/04/12/evolution.html). Since raster 3.6.3, all use of external FOSS library functionality has been transferred to terra, making the retiring packages very likely redundant. It would help greatly if you could remove dependencies on the retiring packages as soon as possible.

@rsbivand
Copy link
Author

You will be aware, for example from:
https://r-spatial.org/r/2022/04/12/evolution.html,
https://r-spatial.org/r/2022/12/14/evolution2.html,
https://r-spatial.org/r/2023/04/10/evolution3.html and
https://rsbivand.github.io/csds_jan23/bivand_csds_ssg_230117.pdf and
perhaps view https://www.youtube.com/watch?v=TlpjIqTPMCA&list=PLzREt6r1NenmWEidssmLm-VO_YmAh4pq9&index=1
that rgdal, rgeos and maptools will be retired this
year, in October 2023.

The package imports 'rgdal', specifically rgdal::writeOGR in NAMESPACE and line 37 in export.R. Ad discussed in https://r-spatial.org/r/2023/04/10/evolution3.html and in links given there, and since you use raster which depends on terra, coercion to vect and terra::writeVector probably provide the easiest mitigation. Please act very soon, best by June, latest by October 2023.

@achubaty
Copy link
Owner

Thank you, I will make the changes in the next few weeks.

achubaty added a commit that referenced this issue Apr 18, 2023
use sf to write shapefiles
@achubaty
Copy link
Owner

achubaty commented Apr 19, 2023

removed dependencies rgdal and rgeos in e10b0ab.

converting from sp/raster to sf/terra will take much more work (#69)

@ecologics
Copy link
Collaborator

ecologics commented Apr 19, 2023 via email

@achubaty
Copy link
Owner

We should definitely move to using it (and still allow RasterLayer objects to be used). It's straightforward to do so, but will require converting most of the package code and adding corresponding tests.

@rsbivand
Copy link
Author

Yes, it is very sensible adding tests so that you can see whether the changes in the underlying software impact output (this both includes dropping retiring packages, and the frequent updates in PROJ, GDAL and GEOS).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants