Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heartbeat lockdown #10

Open
rauhul opened this issue Apr 4, 2017 · 5 comments
Open

Heartbeat lockdown #10

rauhul opened this issue Apr 4, 2017 · 5 comments

Comments

@rauhul
Copy link
Member

rauhul commented Apr 4, 2017

The service should prevent any further requests to Merch if the pi does not response to a heartbeat sent out by this service. This will allow us to know as soon as the service goes down. This sort of heartbeat will be very useful for Concert and other future services and Merch provides a good platform to test it on.

@narendasan
Copy link
Member

This would probably be better as a canopy feature if anything

@narendasan
Copy link
Member

Also i think that ideally commands would not be synchronous, so state changes about the queue, or the inventory is not changed until a success confirmation from merch. so this could just be implemented as a timeout in the context of this service

@abrandemuehl
Copy link

Would it be possible to make something like a swagger API spec that I could generate the code from? That would make it much easier on my end, and we could reuse for other services.

I don't want to have to update it manually if the heartbeat API changes

@narendasan
Copy link
Member

@abrandemuehl add it as an issue in https://github.com/acm-uiuc/canopy. I can develop a code stub that can be inserted for supported languages

@narendasan
Copy link
Member

But I dont want to have groot trying to figure out uptime, it should work in a way where it assumes it works and handles failures. We are currently in the process of creating a service monitor for figuring out system status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants