Remove stale cookies from login page #78
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WishingWell13
requested review from
echang594,
jennymar and
alexzhang1618
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks for contributing! |
angela139
reviewed
Feb 4, 2025
SheepTester
reviewed
Feb 5, 2025
There was a problem hiding this comment.
you can delete this, we switched to using a route handler instead
| @@ -15,6 +15,7 @@ import { getErrorMessage } from '../utils'; | |||
|
|
|||
| export const login = async (email: string, password: string): Promise<LoginResponse> => { | |||
| const requestUrl = `${config.api.baseUrl}${config.api.endpoints.auth.login}`; | |||
| console.log('requestUrl', requestUrl); | |||
| @@ -1,6 +1,7 @@ | |||
| ## Setup | |||
|
|
|||
| 1. Copy `.env.example` to `.env` and fill in the values | |||
| 1. If you are on ACM @ UCSD Dev Team, fields are available in our google drive for step 1 and 2 | |||
There was a problem hiding this comment.
can you undo this change (so there are no changes to the server/ folder), otherwise I think merging your PR might take down both portals while the backend action runs
| @@ -12,7 +12,7 @@ export default async function Home() { | |||
|
|
|||
| if (!accessToken) { | |||
| console.log('Dashboard broke: access token undefined'); | |||
| redirect('/login'); | |||
| redirect('/api/logout'); | |||
There was a problem hiding this comment.
you might also need to update the application and profile edit pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Info
Closes #79 (If there is no issue for this pull request yet, please create one or
delete this line if the pull request is for a very minor tweak).
Description
What changes did you make? List all distinct problems that this PR addresses. Explain any relevant
motivation or context.
Bug fixes regarding cookies and the login page
Changes
Type of Change
expected)
workflows, linting, etc.)
If you've selected Patch, Minor, or Major as your change type, make sure to bump the version before merging in
package.json!Testing
I have tested that my changes fully resolve the linked issue ...
Checklist
package.jsonfile.Screenshots
Please include a screenshot of your Postman testing passing successfully.