Fix signed/unsigned comparison for subsystem ID #77
Conversation
| return bdx_dev_tbl[i].phy_type; | ||
| } | ||
| return 0; | ||
| return PHY_TYPE_NA; | ||
| } |
There was a problem hiding this comment.
Change return type of the function to enum PHY_TYPE. (minor, doesn't hinder merge)
There was a problem hiding this comment.
Thank you for the feedback. I did a commit to the same branch and it looks like that included it in the same pull request automatically. (still finding my way around git and github) Please let me know if there are other issues or comments.
There was a problem hiding this comment.
Thanks, it looks good now. Another minor code style issue is a space before the first { in the if body.
I don't have merge rights, so we'll have to wait until someone that has, comes around.
tn40.c
Outdated
| return PHY_TYPE_NA; /* NIC definition has no PHY. */ | ||
|
|
||
| } | ||
| bdx_mdio_set_speed(priv->pBdxRegs, MDIO_SPEED_1MHZ); |
There was a problem hiding this comment.
Indent with a hard tab to follow the codestyle in the rest of the file. Also one more occurance below. (minor, doesn't hinder merge)
The PHY table used a signed device "subdev". My subdev is 0x8103 (MSB set) which failed the table lookup despite 0x8103 being in the table.
This changes the table type from "short" to "__u16" to make the comparison work correctly.
Tested with my Edimax EN-9320SFP+, Intel HP620 workstation, Ubuntu 24.04, kernel 6.8.0-49-generic.
I can only test bandwidth upto 1 Gbit through my switch since I only have one 10 Gbit device, but the reported link speed to the switch is 10 Gbit.
fixes #76