Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving the BLT EnvironmentDetector into this library #33

Open
jhedstrom opened this issue Mar 1, 2022 · 3 comments
Open

Consider moving the BLT EnvironmentDetector into this library #33

jhedstrom opened this issue Mar 1, 2022 · 3 comments

Comments

@jhedstrom
Copy link

There is some pretty useful additions the the environment detector, currently bundled within BLT, that would be nice to have in this project. The use case is for projects that are not using all of BLT, but would still like consistent detection across platforms.

There are probably some things in there that would need to remain BLT-specific, but most of the methods appear to be agnostic of BLT.

@danepowell
Copy link
Contributor

I'm open to the idea, but could you be more specific about what you're interested in porting?

Most of the methods in BLT's detector are specific to certain environments (Pantheon, Travis, Pipelines, etc), or they deal with BLT-isms like detector overrides, and I'd prefer to exclude those from this library.

@jhedstrom
Copy link
Author

The methods that initially made me realize it wasn't already part of this project were the Pantheon detection ones. Honestly I'd say any of the methods that only rely on this library could be moved here to allow broader use outside of BLT projects.

@jonpugh
Copy link

jonpugh commented Apr 3, 2023

@jhedstrom @danepowell

I think we need a drupal/environment-detector that all the other environment detectors can extend.

A dev can dream....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants