Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for /etc/lsb-release before reading it #28

Open
william-stearns opened this issue Jan 11, 2023 · 0 comments
Open

Check for /etc/lsb-release before reading it #28

william-stearns opened this issue Jan 11, 2023 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@william-stearns
Copy link
Contributor

Cosmetic: grep tries to read the file even if it's not there.
Change:
check_os_is_ubuntu () {
grep -iq '^DISTRIB_ID *= *Ubuntu' /etc/lsb-release
}
to:
check_os_is_ubuntu () {
[ -s /etc/lsb-release ] && grep -iq '^DISTRIB_ID *= *Ubuntu' /etc/lsb-release
}

@william-stearns william-stearns added bug Something isn't working good first issue Good for newcomers labels Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant