diff --git a/packages/loot-core/src/server/api.ts b/packages/loot-core/src/server/api.ts index 2d67d5e9c06..885d21fc050 100644 --- a/packages/loot-core/src/server/api.ts +++ b/packages/loot-core/src/server/api.ts @@ -204,6 +204,7 @@ handlers['api/download-budget'] = async function ({ syncId, password }) { let result = await handlers['download-budget']({ fileId: file.fileId }); if (result.error) { + console.log('Full error details', result.error); throw new Error(getDownloadError(result.error)); } await handlers['load-budget']({ id: result.id }); diff --git a/packages/loot-core/src/shared/errors.ts b/packages/loot-core/src/shared/errors.ts index 61b16f4f15d..1f62874da64 100644 --- a/packages/loot-core/src/shared/errors.ts +++ b/packages/loot-core/src/shared/errors.ts @@ -51,10 +51,11 @@ export function getDownloadError({ reason, meta, fileName }) { ); default: - let info = meta && meta.fileId ? `(fileId: ${meta.fileId})` : ''; + let info = meta && meta.fileId ? `, fileId: ${meta.fileId}` : ''; return ( - 'Something went wrong trying to download that file, sorry! Visit https://actualbudget.org/contact/ for support. ' + - info + 'Something went wrong trying to download that file, sorry! ' + + 'Visit https://actualbudget.org/contact/ for support. ' + + `(reason: ${reason}${info})` ); } } diff --git a/upcoming-release-notes/1396.md b/upcoming-release-notes/1396.md new file mode 100644 index 00000000000..8213e5fc03d --- /dev/null +++ b/upcoming-release-notes/1396.md @@ -0,0 +1,6 @@ +--- +category: Enhancements +authors: [j-f1] +--- + +Improve error messaging when the API package fails to download a file