Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

animated has too few big pixel #13

Open
osafaimal opened this issue Jan 7, 2023 · 2 comments
Open

animated has too few big pixel #13

osafaimal opened this issue Jan 7, 2023 · 2 comments

Comments

@osafaimal
Copy link

osafaimal commented Jan 7, 2023

hello,
i've download the release and run the install.sh and i have this. I use kitty.
image
and i've this problem too
image
can you help me to correct these problems?
I know it's like a repost of #7 but it didn't solved my problem

@osafaimal
Copy link
Author

parse error: Invalid numeric literal at line 1, column 4
convert: unable to open image 'pickachu+male-big.png': No such file or directory @ error/blob.c/OpenBlob/3570.
convert: no images defined `/home/roza/.cache/pokeshell/not-shiny:pickachu+male-big.png' @ error/convert.c/ConvertImageCommand/3342.
convert: unable to open image 'pickachu+male-big.png': No such file or directory @ error/blob.c/OpenBlob/3570.
convert: no images defined `/home/roza/.cache/pokeshell/not-shiny:pickachu+male-big.pngp' @ error/convert.c/ConvertImageCommand/3342.
chafa: Failed to open '/home/roza/.cache/pokeshell/not-shiny:pickachu+male-big.pngp': No such file or directory```

@acxz
Copy link
Owner

acxz commented Oct 27, 2024

Okay everyone so here's the thing.

pokeshell uses a set of bash functions called imageshell. Now imageshell in the past used the terminal image viewer timg for displaying. timg is really cool, but one thing it lacks is the support for various unicode symbols. This means that when you specify a bunch of pokemon to display that can't fit normally fit in the terminal window, it will resize and to do a best fit of the image in terms of just quarter blocks. timg is also slightly heavier and slower to use.

at some point I decided to move to chafa so that the resize output based on the terminal size looks better (i.e. chafa has support for more unicode symbols and will be a better fit of the original image)
that's great, but chafa has a couple features (or wip features) that timg does not. One big one for our use case, is the pixel perfect display (hpjansson/chafa#70).

Another one that affects the animation is not respecting transparency in gifs for kitty: hpjansson/chafa#111. Because of this, I decided to disable sixel support and force only unicode symbol support for the gifs.

Due to all the issue open about this throughout the years, I'm considering having a flag for using both timg and chafa and based on a user's preference let them pick. This will allow everyone to get what they want based on their needs (i.e. timg for pixel perfect images and sixel gifs, chafa for better resizing output and unicode based gifs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants