Skip to content
This repository has been archived by the owner on Jan 2, 2021. It is now read-only.

Allow setPeriodicWave on Oscillator with "custom" shape #53

Open
adamrenklint opened this issue Sep 24, 2016 · 0 comments
Open

Allow setPeriodicWave on Oscillator with "custom" shape #53

adamrenklint opened this issue Sep 24, 2016 · 0 comments

Comments

@adamrenklint
Copy link
Owner

Currently the "custom" shape on Oscillators is pretty useless, since a new Oscillator is created for each note playback in lib/Oscillator#_source and there is no place to hook in to call setPeriodicWave on the actual oscillator node.

So there needs to be some kind of hook there, allowing an Oscillator class instance to define a callback to generate the periodic wave, if the shape is custom.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant